Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelci/build.py: fix git_branch_tip #2734

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

JenySadadia
Copy link
Collaborator

Fixes kernelci/kernelci-pipeline#846

Bug: tip_of_branch is always set to False.
Fix the method by stripping subprocess command output to get the correct value for tip_of_branch.

Bug: `tip_of_branch` is always set to `False`.
Fix the method by stripping subprocess command
output to get the correct value for `tip_of_branch`.

Signed-off-by: Jeny Sadadia <[email protected]>
@JenySadadia
Copy link
Collaborator Author

Tested OK locally for pending-fixes branch:

{"id":"672a0ca3dbc8ee69dcc2a96e","kind":"checkout","name":"checkout","path":["checkout"],"group":null,"parent":null,"state":"available","result":null,"artifacts":{"tarball":"http://172.17.0.1:8002/linux-next-pending-fixes-v6.12-rc6-192-g566383b19a74.tar.gz"},"data":{"kernel_revision":{"tree":"next","url":"https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git","branch":"pending-fixes","commit":"566383b19a74825da16da3b567303cb0536411d0","describe":"v6.12-rc6-192-g566383b19a74","version":{"version":6,"patchlevel":12,"extra":"-rc6-192-g566383b19a74"},"commit_tags":[],"commit_message":"Merge branch 'for-linux-next-fixes' of https://gitlab.freedesktop.org/drm/misc/kernel.git","tip_of_branch":true}},"debug":null,"jobfilter":null,"platform_filter":[],"created":"2024-11-05T12:16:35.932000","updated":"2024-11-05T12:17:19.482000","timeout":"2024-11-05T15:16:35.925000","holdoff":"2024-11-05T12:27:19.470000","owner":"test","submitter":"user:[email protected]","treeid":"64d3c4a2c7cb6af96a3ad00855bac31a07de2cf4e207ad371352a687147e1bef","user_groups":[]}

Let's wait for staging results.

@nuclearcat
Copy link
Member

Works. I did 2 custom checkouts, one with tipoftree, another some commit before. It worked:
https://staging.kernelci.org:9000/viewer?node_id=672a0fb419783bdeefcfff51
https://staging.kernelci.org:9000/viewer?node_id=672a0fac19783bdeefcfff47

@nuclearcat nuclearcat added this pull request to the merge queue Nov 5, 2024
Merged via the queue into kernelci:main with commit 8549d0e Nov 5, 2024
4 checks passed
@JenySadadia JenySadadia deleted the fix-tip-of-branch branch November 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tip_of_branch incorrectly set to false
2 participants