fix(tarball/trigger): Change tip of branch logic #859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now by some reason tip_of_branch always false, even trigger points to latest commit in branch. Probably function in kernelci-core should be used differently? Simplify it, we always expect trigger service to watch for tip of branch commit. Signed-off-by: Denys Fedoryshchenko <[email protected]>
JenySadadia
reviewed
Oct 30, 2024
| @@ -82,6 +82,7 @@ def _run_trigger(self, build_config, force, timeout, trees): | |||
| 'kind': 'checkout', | |||
| 'data': { | |||
| 'kernel_revision': revision, | |||
| 'tip_of_branch': True, | |||
There was a problem hiding this comment.
This shouldn't be set statically. We should keep it dynamic.
There was a problem hiding this comment.
In trigger it is by definition tip of tree:
head_commit = kernelci.build.get_branch_head(build_config)
so it is expected that trigger.py generates only branch head which is same meaning as tip of branch.
|
kernelci/kernelci-core#2734 would fix the issue in core function. |
JenySadadia
added
the
staging-skip
|
Let's test it, then i will close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now by some reason tip_of_branch always false, even trigger points to latest commit in branch.
Probably function in kernelci-core should be used differently? Simplify it, we always expect trigger service to watch for tip of branch commit.