pkg/search/controllers_test: fix flaky test cases #5833
Conversation
karmada-bot
added
the
kind/failing-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/L
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5833 +/- ##
==========================================
+ Coverage 46.30% 46.34% +0.04%
==========================================
Files 661 661
Lines 54308 54306 -2
==========================================
+ Hits 25147 25169 +22
+ Misses 27536 27515 -21
+ Partials 1625 1622 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
/retest |
mohamedawnallah
force-pushed
the
fixKarmadaSearchControllerFlakyTestCases
branch
from
aecbb6f
to
1345ad6
Compare
|
cc @zhzhuang-zju All test cases passed now :) |
Signed-off-by: changzhen <[email protected]>
In this commit, we fix flaky test cases mainly by increasing the timeout from 250 milliseconds to 500 milliseconds. Signed-off-by: Mohamed Awnallah <[email protected]>
mohamedawnallah
force-pushed
the
fixKarmadaSearchControllerFlakyTestCases
branch
from
1345ad6
to
dada7d2
Compare
|
Replaced by #5856 |
Description
In this commit, we fix flaky test cases mainly by increasing the timeout from 250 milliseconds to 500 milliseconds.
What type of PR is this?
/kind failing-test
Which issue(s) this PR fixes:
Fixes #5810 (comment)
Does this PR introduce a user-facing change?: