-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for the CustomizedInterpreter #5838
Added unit tests for the CustomizedInterpreter #5838
Conversation
Hi @mohamedawnallah , found some flaky tests. |
Hi @anujagrawal699, Thanks for pointing this out! I've already submitted a PR for this (#5833). |
/retest |
Signed-off-by: Anuj Agrawal <[email protected]> Added unit tests for the CustomizedInterpreter Signed-off-by: Anuj Agrawal <[email protected]>
a84f53e
to
c2bc07b
Compare
@anujagrawal699 thanks for your work! I've noticed that most of the functions only cover the scenarios of 'hook not synced' and 'no matching hooks.' However, it's challenging to construct successful scenarios, and the newly added tests have retained the extensibility for related scenarios. Therefore, I believe it is acceptable to merge them in. /lgtm |
Thanks @zhzhuang-zju , the successful interpretation scenarios are hard to test and will require complex mocking and thus we should move ahead with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This PR adds comprehensive unit tests for the customized webhook interpreter. These tests verify the core functionality of webhook interpretation operations including replica retrieval, dependencies handling, patch operations and webhook enabling.
Additions:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: