Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for the CustomizedInterpreter #5838

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR adds comprehensive unit tests for the customized webhook interpreter. These tests verify the core functionality of webhook interpretation operations including replica retrieval, dependencies handling, patch operations and webhook enabling.

Additions:

  1. pkg/resourceinterpreter/customized/webhook/customized_test.go

Test Coverage:

  1. pkg/resourceinterpreter/customized/webhook/customized.go : 0% to 65%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 19, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 19, 2024
@anujagrawal699
Copy link
Contributor Author

Hi @mohamedawnallah , found some flaky tests.

@mohamedawnallah
Copy link
Contributor

mohamedawnallah commented Nov 20, 2024

Hi @anujagrawal699, Thanks for pointing this out! I've already submitted a PR for this (#5833).

@zhzhuang-zju
Copy link
Contributor

/retest
/assign

Signed-off-by: Anuj Agrawal <[email protected]>

Added unit tests for the CustomizedInterpreter

Signed-off-by: Anuj Agrawal <[email protected]>
@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/resourceinterpreter/customized/webhook/customized.go branch from a84f53e to c2bc07b Compare November 20, 2024 05:17
@zhzhuang-zju
Copy link
Contributor

@anujagrawal699 thanks for your work! I've noticed that most of the functions only cover the scenarios of 'hook not synced' and 'no matching hooks.' However, it's challenging to construct successful scenarios, and the newly added tests have retained the extensibility for related scenarios. Therefore, I believe it is acceptable to merge them in.

/lgtm
cc @XiShanYongYe-Chang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@anujagrawal699
Copy link
Contributor Author

@anujagrawal699 thanks for your work! I've noticed that most of the functions only cover the scenarios of 'hook not synced' and 'no matching hooks.' However, it's challenging to construct successful scenarios, and the newly added tests have retained the extensibility for related scenarios. Therefore, I believe it is acceptable to merge them in.

/lgtm cc @XiShanYongYe-Chang

Thanks @zhzhuang-zju , the successful interpretation scenarios are hard to test and will require complex mocking and thus we should move ahead with this.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@karmada-bot karmada-bot merged commit f6056f5 into karmada-io:master Nov 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants