Remove unnecessary 'request-timeout=300s' parameter from CIS hardening guide #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agterdenbos
force-pushed
the
feature/cis-hardening-remove-request-timeout
branch
from
ce35bc1 to
3fdfaab
Compare
dereknola
approved these changes
Apr 17, 2024
brandond
approved these changes
Apr 17, 2024
Signed-off-by: Erik Agterdenbos <[email protected]>
Signed-off-by: Erik Agterdenbos <[email protected]>
dereknola
force-pushed
the
feature/cis-hardening-remove-request-timeout
branch
from
33e032f to
461a31f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIS recommends to set the
--request-timeoutparameter only when necessary. The default already limits requests to 60 seconds and increasing this would not improve the security. Hence, the suggestion to increase this parameter to 300 seconds should be removed from the hardening guide.