Skip to content

Commit

Permalink
Remove unnecessary 'request-timeout=300s' parameter from CIS hardenin…
Browse files Browse the repository at this point in the history
…g guide (#267)

* Remove unnecessary 'request-timeout=300s' from hardening guide

Signed-off-by: Erik Agterdenbos <[email protected]>

* Also remove 'request-timeout=300s' for other languages

Signed-off-by: Erik Agterdenbos <[email protected]>

---------

Signed-off-by: Erik Agterdenbos <[email protected]>
  • Loading branch information
agterdenbos authored Jul 16, 2024
1 parent 4d364af commit 3b7fbe8
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 13 deletions.
1 change: 0 additions & 1 deletion docs/known-issues.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ kube-apiserver-arg:
- 'audit-log-maxage=30'
- 'audit-log-maxbackup=10'
- 'audit-log-maxsize=100'
- 'request-timeout=300s'
kube-controller-manager-arg:
- 'terminated-pod-gc-threshold=10'
- 'use-service-account-credentials=true'
Expand Down
2 changes: 0 additions & 2 deletions docs/security/hardening-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,6 @@ kube-apiserver-arg:
- 'audit-log-maxage=30'
- 'audit-log-maxbackup=10'
- 'audit-log-maxsize=100'
- 'request-timeout=300s'
kube-controller-manager-arg:
- 'terminated-pod-gc-threshold=10'
- 'use-service-account-credentials=true'
Expand All @@ -596,7 +595,6 @@ kube-apiserver-arg:
- 'audit-log-maxage=30'
- 'audit-log-maxbackup=10'
- 'audit-log-maxsize=100'
- 'request-timeout=300s'
kube-controller-manager-arg:
- 'terminated-pod-gc-threshold=10'
- 'use-service-account-credentials=true'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ kube-apiserver-arg:
- "audit-log-maxage=30"
- "audit-log-maxbackup=10"
- "audit-log-maxsize=100"
- "request-timeout=300s"
kube-controller-manager-arg:
- "terminated-pod-gc-threshold=10"
- "use-service-account-credentials=true"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,6 @@ kube-apiserver-arg:
- 'audit-log-maxage=30'
- 'audit-log-maxbackup=10'
- 'audit-log-maxsize=100'
- 'request-timeout=300s'
kube-controller-manager-arg:
- 'terminated-pod-gc-threshold=10'
- 'use-service-account-credentials=true'
Expand All @@ -598,7 +597,6 @@ kube-apiserver-arg:
- 'audit-log-maxage=30'
- 'audit-log-maxbackup=10'
- 'audit-log-maxsize=100'
- 'request-timeout=300s'
kube-controller-manager-arg:
- 'terminated-pod-gc-threshold=10'
- 'use-service-account-credentials=true'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1004,10 +1004,14 @@ Sep 13 13:26:40 k3s-123-cis-pool3-b403f678-bzdg5 k3s[1600]: time="2022-09-13T13:
**Result:** Not Applicable

**Remediation:**
Edit the API server pod specification file /etc/kubernetes/manifests/kube-apiserver.yaml
on the control plane node and set the --service-account-key-file parameter
to the public key file for service accounts. For example,
`--service-account-key-file=<filename>`.
The request timeout limits the duration of API requests. The default value of 60 seconds is
sufficiently low already. Only change the default value if necessary. When extending this
limit, make sure to keep it low enough. A large value can exhaust API server resources and
make it prone for Denial-of-Service attacks.

Edit the config file /etc/rancher/k3s/config.yaml on the control plane node and remove the
--request-timeout parameter or set it to an appropriate value if needed. For example,
`--request-timeout=300s`.

### 1.2.26 Ensure that the --etcd-certfile and --etcd-keyfile arguments are set as appropriate (Automated)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ kube-apiserver-arg:
- 'audit-log-maxage=30'
- 'audit-log-maxbackup=10'
- 'audit-log-maxsize=100'
- 'request-timeout=300s'
kube-controller-manager-arg:
- 'terminated-pod-gc-threshold=10'
- 'use-service-account-credentials=true'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,6 @@ kube-apiserver-arg:
- 'audit-log-maxage=30'
- 'audit-log-maxbackup=10'
- 'audit-log-maxsize=100'
- 'request-timeout=300s'
kube-controller-manager-arg:
- 'terminated-pod-gc-threshold=10'
- 'use-service-account-credentials=true'
Expand All @@ -601,7 +600,6 @@ kube-apiserver-arg:
- 'audit-log-maxage=30'
- 'audit-log-maxbackup=10'
- 'audit-log-maxsize=100'
- 'request-timeout=300s'
kube-controller-manager-arg:
- 'terminated-pod-gc-threshold=10'
- 'use-service-account-credentials=true'
Expand Down

0 comments on commit 3b7fbe8

Please sign in to comment.