Downgraded Firebase Functions from Node 22 to 20

[jwngr]

See firebase/firebase-functions#1653

Summary by CodeRabbit

• New Features

  • Added new environment variables for Firebase function deployments.
  • Introduced validation checks for required secrets during deployment.

• Bug Fixes

  • Improved error handling for missing secrets in deployment workflows.

• Configuration Changes

  • Updated Firebase functions configuration to specify the runtime environment as Node.js 20.

[coderabbitai]

Walkthrough

The pull request introduces changes to the Firebase deployment workflow and configuration across multiple files. In the GitHub Actions workflow files for merge and pull request scenarios, two new environment secrets, SUPERFEEDR_USER and SUPERFEEDR_API_KEY, are added. These secrets are validated during the deployment process, with the workflow exiting if either is missing. The .env.conductor-prod and .env.conductor-stag files are updated to include these new variables.

Additionally, the firebase.json configuration file is modified to specify the Node.js runtime version as nodejs20, updating the execution environment for Firebase functions. These changes enhance the deployment process by adding more robust secret validation and updating the runtime environment.

Sequence Diagram

sequenceDiagram
    participant GA as GitHub Actions
    participant Secrets as GitHub Secrets
    participant Env as Environment Setup
    participant Firebase as Firebase Deployment

    GA->>Secrets: Check SUPERFEEDR_USER
    GA->>Secrets: Check SUPERFEEDR_API_KEY
    alt Secrets Missing
        GA-->>GA: Exit with Error
    else Secrets Present
        GA->>Env: Create .env file
        Env->>Env: Append Secrets
        Env->>Firebase: Deploy Functions
        Firebase-->>GA: Deployment Result
    end

Loading

The sequence diagram illustrates the workflow's validation process, showing how the presence of secrets is checked before proceeding with environment setup and Firebase function deployment.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 581eb10 and de5366c.

📒 Files selected for processing (3)

• .github/workflows/firebase-functions-merge.yml (1 hunks)
• .github/workflows/firebase-functions-pull-request.yml (1 hunks)
• firebase.json (1 hunks)

🔇 Additional comments (4)

firebase.json (1)

36-36: LGTM! Good choice downgrading to Node.js 20 LTS

The downgrade to Node.js 20 is a good decision as it's a Long Term Support (LTS) version, providing better stability and security support until April 2026. This is more suitable for production deployments compared to Node.js 22 which is not yet an LTS release.

.github/workflows/firebase-functions-merge.yml (2)

45-52: LGTM! Proper environment variable validation

The validation logic for the new environment variables is well-implemented with clear error messages.

Also applies to: 54-55

---

38-39: Additional feature detected: Superfeedr integration

These changes appear to be unrelated to the Node.js version downgrade. They introduce Superfeedr integration, which seems to be a separate feature. Consider splitting this into a separate PR to maintain clear change tracking and easier rollback if needed.

Let's verify the purpose of these new environment variables:

.github/workflows/firebase-functions-pull-request.yml (1)

40-41: LGTM! Consistent implementation across environments

The changes mirror those in the merge workflow, maintaining consistency between staging and production environments. The environment variables are correctly configured for the staging environment.

Also applies to: 47-54, 56-57

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Visit the preview URL for this PR (updated for commit de5366c):

https://conductor-stag--pr113-jw-firebase-function-0v0pavqp.web.app

_{(expires Tue, 31 Dec 2024 21:29:15 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 834e855d1f1172274ecc7a165f6956c157c874fb}