Downgraded Firebase Functions from Node 22 to 20 (#113)

* Downgraded Firebase Functions from Node 22 to 20 * Added Superfeedr API env variables
jwngr · Dec 24, 2024 · 9a2c30f · 9a2c30f
1 parent 581eb10
commit 9a2c30f
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/.github/workflows/firebase-functions-merge.yml b/.github/workflows/firebase-functions-merge.yml
@@ -35,12 +35,24 @@ jobs:
         working-directory: packages/functions
         env:
           FIRECRAWL_API_KEY: ${{ secrets.FIRECRAWL_API_KEY }}
+          SUPERFEEDR_USER: ${{ secrets.SUPERFEEDR_USER }}
+          SUPERFEEDR_API_KEY: ${{ secrets.SUPERFEEDR_API_KEY }}
         run: |
           if [ -z "$FIRECRAWL_API_KEY" ]; then
             echo "Error: FIRECRAWL_API_KEY secret must be added in GitHub"
             exit 1
           fi
+          if [ -z "$SUPERFEEDR_USER" ]; then
+            echo "Error: SUPERFEEDR_USER secret must be added in GitHub"
+            exit 1
+          fi
+          if [ -z "$SUPERFEEDR_API_KEY" ]; then
+            echo "Error: SUPERFEEDR_API_KEY secret must be added in GitHub"
+            exit 1
+          fi
           echo "FIRECRAWL_API_KEY=${FIRECRAWL_API_KEY}" > .env.conductor-prod
+          echo "SUPERFEEDR_USER=${SUPERFEEDR_USER}" >> .env.conductor-prod
+          echo "SUPERFEEDR_API_KEY=${SUPERFEEDR_API_KEY}" >> .env.conductor-prod
       - name: Deploy Firebase Functions
         env:
           FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}

diff --git a/.github/workflows/firebase-functions-pull-request.yml b/.github/workflows/firebase-functions-pull-request.yml
@@ -37,12 +37,24 @@ jobs:
         working-directory: packages/functions
         env:
           FIRECRAWL_API_KEY: ${{ secrets.FIRECRAWL_API_KEY }}
+          SUPERFEEDR_USER: ${{ secrets.SUPERFEEDR_USER }}
+          SUPERFEEDR_API_KEY: ${{ secrets.SUPERFEEDR_API_KEY }}
         run: |
           if [ -z "$FIRECRAWL_API_KEY" ]; then
             echo "Error: FIRECRAWL_API_KEY secret must be added in GitHub"
             exit 1
           fi
+          if [ -z "$SUPERFEEDR_USER" ]; then
+            echo "Error: SUPERFEEDR_USER secret must be added in GitHub"
+            exit 1
+          fi
+          if [ -z "$SUPERFEEDR_API_KEY" ]; then
+            echo "Error: SUPERFEEDR_API_KEY secret must be added in GitHub"
+            exit 1
+          fi
           echo "FIRECRAWL_API_KEY=${FIRECRAWL_API_KEY}" > .env.conductor-stag
+          echo "SUPERFEEDR_USER=${SUPERFEEDR_USER}" >> .env.conductor-stag
+          echo "SUPERFEEDR_API_KEY=${SUPERFEEDR_API_KEY}" >> .env.conductor-stag
       - name: Deploy Firebase Functions
         env:
           FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}

diff --git a/firebase.json b/firebase.json
@@ -33,6 +33,7 @@
   "functions": [
     {
       "source": "packages/functions",
+      "runtime": "nodejs20",
       "ignore": ["node_modules", ".git", "firebase-debug.log", "firebase-debug.*.log", "*.local"]
     }
   ]