Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending empty input with Enter #946

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

michaelchia
Copy link
Collaborator

Prevents "Enter" triggering send message on empty input.

Fixes #800

@krassowski krassowski added the bug Something isn't working label Aug 12, 2024
@srdas
Copy link
Collaborator

srdas commented Aug 12, 2024

Tested this branch and the fix is working as intended. Tested for blanks and whitespaces as well.

Thank you very much for this PR!

@srdas srdas merged commit 2c9523f into jupyterlab:main Aug 12, 2024
8 checks passed
@michaelchia michaelchia deleted the prevent-empty-enter branch September 4, 2024 05:49
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending an empty message results in a silent server error
3 participants