Prevent sending empty message #126
Conversation
|
|
brichet
force-pushed
the
do_not_send_empty
branch
from
5ad6a80 to
6aab0e6
Compare
| // Do not send empty messages, and avoid adding new line in empty message. | ||
| if (!input.trim()) { | ||
| event.stopPropagation(); | ||
| event.preventDefault(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This handler only sends the message if !input.trim(), but the SendButton component is enabled by a different condition (when input.length >= 0).
<SendButton
model={model}
sendWithShiftEnter={sendWithShiftEnter}
inputExists={input.length > 0}
onSend={onSend}
hideIncludeSelection={hideIncludeSelection}
hasButtonOnLeft={!!props.onCancel}
/>Currently, if the input contains only white space, the send button will be enabled (which shouldn't happen), but pressing Enter/Shift-Enter does nothing. This is a difference in behavior caused by using two separate state variables.
I recommend defining a new local variable const inputExists = !!input.trim() in the component's top scope, and using that variable in both the handler & the send button.
There was a problem hiding this comment.
Good catch, thanks
There was a problem hiding this comment.
Updated in b28a698
|
The condition to disable the button was also applied to the 'cancel' button (visible when editing a message). |
Fixes #118
Port jupyterlab/jupyter-ai#946
EDIT