-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core Enhancement 3 - Merge Featured into Articles #11
base: dev
Are you sure you want to change the base?
Core Enhancement 3 - Merge Featured into Articles #11
Conversation
About the menuItem "Featured Articles". Could we remove the link to featured articles from the backend? Or is it a b/c break ? Needs to be discussed |
Good Point. |
The purpose of this PR is to track all the file changes and commits made. Mentors can review the changes and provide feedback.
I will update the description as and when I push more commits.
Plan Document: https://docs.google.com/document/d/1Pl8JGa2hkYkmJzQOn9_mS8a4imDmqc2a/edit#heading=h.t5tri5tytv7q
view=featured
Edit: Merge Table has been removed from the above list because I feel that both the files (in /src/Table/) play an essential role and they must be different
Summary of Changes
[A] New Selector Dropdown
A searchtools selector is added that can be used to toggle between:
[B] Model Merged
$featured
variable is used as a condition to manipulate the query to adjust to Featured[C] Templates Merged
state->get('featured')
to conditonally render the template code as per featured or not.[D] Views Merged
state->get('featured')
to conditonally render the toolbar options[E] Controller Merged
Testing Instructions
Expected result AFTER applying this Pull Request
Everything works normally