[5.2] [GSoC 21] Core Enhancement 3 - Merge Featured into Articles

[YatharthVyas]

Project Repo PR: joomla-projects/gsoc21_core-enhancements#11
Plan Document: https://docs.google.com/document/d/1Pl8JGa2hkYkmJzQOn9_mS8a4imDmqc2a/edit#heading=h.t5tri5tytv7q

---

• Drop-down selector in Articles view
• Merge Model
• Merge tmpl files
• Merge View
• Merge Controller
• Update all links pointing to view=featured
• Update Link of Featured Articles Menu Item
• Remove Featured files

Summary of Changes

[A] New Selector Dropdown

A searchtools selector is added that can be used to toggle between:

Option	Value
All	""
Unfeatured	0
Featured	1

[B] Model Merged

• A new method to return the featured selector filter parameter using the getUserState from request

$featured = $this->getUserStateFromRequest($this->context . '.featured', 'featured', '');

• The advantage of the above is that we can also pass the value as a GET param to the URL which helps us to make redirect URLs that can initialize the value of this dropdown
• $featured variable is used as a condition to manipulate the query to adjust to Featured

[C] Templates Merged

• We use state->get('featured') to conditonally render the template code as per featured or not.

[D] Views Merged

• We use state->get('featured') to conditonally render the toolbar options

[E] Controller Merged

• Merged the delete function from FeaturedController

Testing Instructions

• Visit the Articles View and ensure that everything works as it did before.
• Test workflows and filters too
• Ensure that the tmpl and view (and all other MVC files) are common for both featured and articles

Expected result AFTER applying this Pull Request

Everything works normally

Mentors

@chmst @nibra @bembelimen
(and thanks @richard67)

[brianteeman]

its a moved file from
administrator/components/com_content/tmpl/featured/default_stage_footer.php

[brianteeman]

as above its not new just moved

[YatharthVyas]

Does this fix #29942 ?

Sadly, No.
I haven't made any change that affects this.

[Bakual]

If you only moved the "Featured" filter to set it using GET, that works as well with: /administrator/index.php?option=com_content&view=articles&filter[featured]=1.

[Quy]

Sorting by Featured does not update the icon-sort to caret up/caret down.

[YatharthVyas]

Updates:

1. This has been fixed:

Sorting by Featured does not update the icon-sort to caret up/caret down.

2. All old files related to featured articles have been deleted

[Quy]

Will Featured Articles in the sidebar be removed?

[YatharthVyas]

Will Featured Articles in the sidebar be removed?

No, it will stay but it's navigation url will be different. This new url will point to the articles (instead of featured) view and it will pass the filter of featured=1 that will be applied in the search tools to only show featured articles

[Quy]

Two menu items are highlighted. Also, see #28003 for request to remove it.

[brianteeman]

The double highlighting is because of an unrelated bug in menu highlighting

[chmst]

#19886 could be obsolete for 4.x with this PR

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35228.}

[HLeithner]

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

[HLeithner]

This pull request has been automatically rebased to 5.1-dev.

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[ChrisHoefliger]

I have tested this item 🔴 unsuccessfully on 293c6b9

On applying this I get the following error as soon as I open the list of articles:

500 Layout default_batch_footer not found.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35228.}

[richard67]

On applying this I get the following error as soon as I open the list of articles:

500 Layout default_batch_footer not found.

@ChrisHoefliger Please check each pull request (PR) on GitHub before testing. If the PR shows conflicting files at the bottom on GitHub, it doesn't make much sense to test it. Please change back your test result to "Not tested". Thanks in advance.

[crimle]

I have tested this item 🔴 unsuccessfully on 293c6b9

Before applying teh patch, astonishingly the feature was already there.
After applying the patch, I am getting this error:
An error has occurred.
500 Layout default_batch_footer not found.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35228.}

[ChrisHoefliger]

I have not tested this item.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35228.}

[brianteeman]

I have tested this item 🔴 unsuccessfully on 293c6b9Before applying teh patch, astonishingly the feature was already there. After applying the patch, I am getting this error: An error has occurred. 500 Layout default_batch_footer not found.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35228.

You must have misunderstood as it is not already present

[brianteeman]

Thank you @brianteeman for pointing this out. We are going to contact student and mentor about this enhancement as it was a GSoC project. We will also double-check with the UX team on this one.

??

[cybersalt]

I have tested this item 🔴 unsuccessfully on 293c6b9

I tested this and got a 500 error. Here is the error stack:

An error has occurred.
500 Layout default_batch_footer not found.
Call Stack

Function Location

1 () JROOT/libraries/src/MVC/View/HtmlView.php:425
2 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/administrator/components/com_content/tmpl/articles/default.php:416
3 include() JROOT/libraries/src/MVC/View/HtmlView.php:416
4 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/libraries/src/MVC/View/HtmlView.php:204
5 Joomla\CMS\MVC\View\HtmlView->display() JROOT/administrator/components/com_content/src/View/Articles/HtmlView.php:151
6 Joomla\Component\Content\Administrator\View\Articles\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
7 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/administrator/components/com_content/src/Controller/DisplayController.php:65
8 Joomla\Component\Content\Administrator\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
9 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
10 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
11 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
12 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
13 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
14 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
15 require_once() JROOT/administrator/index.php:32

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35228.}

[richard67]

I have tested this item 🔴 unsuccessfully on 293c6b9I tested this and got a 500 error. Here is the error stack:

@cybersalt I would say that's expected. If you go to this PR here on GitHub #35228 and scroll to the bottom you will see that this PR has lots of conflicting files. As long as this is the case, it doesn't make sense to test this PR.

See also my previous comment here #35228 (comment) .

[chmst]

This PR is so good and should go into 6.0 due to b/c breaks it cannot go into 5.x.
Meanwhile there were so many changes also in code styles, that a new PR is open. #43907.
The new one is based completely on this one - all descriptions and instructions are still valid.

Closing this one for now to avoid confusion.