Fixed bug in Node#find
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a bucket, as longs as the desired entry was found somewhere in the bucket.
jonhoo
reviewed
Jan 24, 2020
jonhoo
reviewed
Jan 24, 2020
jonhoo
reviewed
Jan 24, 2020
|
Great catch, thanks! |
This was referenced Jan 24, 2020
Merged
jonhoo
reviewed
Jan 24, 2020
jonhoo
reviewed
Jan 24, 2020
jonhoo
reviewed
Jan 24, 2020
jonhoo
reviewed
Jan 24, 2020
jonhoo
reviewed
Jan 24, 2020
jonhoo
reviewed
Jan 24, 2020
|
Haha, sorry, I just merged #25, so you'll need to resolve conflicts with |
jonhoo
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
findwould always return the first entry in a bucket, as longs as the desired entry was found somewhere in the bucket. This can be replicated by reverting the change inlib/node.rs.At the same time, I added two new constructors of
FlurryHashMap, which can take a custom Hasher: the architecture allowed other hashers to be used, but we couldn't actually build anyFlurryinstances beforehand.