Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "standard" map/collection methods #10

Closed
1 task
jonhoo opened this issue Jan 23, 2020 · 13 comments
Closed
1 task

Implement "standard" map/collection methods #10

jonhoo opened this issue Jan 23, 2020 · 13 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@jonhoo
Copy link
Owner

jonhoo commented Jan 23, 2020

This issue tracks the implementation status of various "standard" methods on collections in general and maps in particular that should be added to flurry. Checked boxes have already been "claimed".

If you want to pick up any of these, leave a comment here and/or open a draft PR!

@jonhoo jonhoo added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 23, 2020
@Stupremee
Copy link
Contributor

I would like to implement Eq, Index and clear.

@jonhoo
Copy link
Owner Author

jonhoo commented Jan 23, 2020

@Stupremee How about you do Eq and Index first, and then we do clear in a separate PR afterwards?

@danielSanchezQ
Copy link
Contributor

I think I can try to implement the Clone one . Is it ok?

@jonhoo
Copy link
Owner Author

jonhoo commented Jan 24, 2020

Absolutely, it's all yours!

@Stupremee
Copy link
Contributor

I will also implement Debug since Index doesnt work atm

@danielSanchezQ
Copy link
Contributor

I think I can do with_hasher and with_capacity_and_hasher also. But I see them as checked already.

@jonhoo
Copy link
Owner Author

jonhoo commented Jan 24, 2020

@danielSanchezQ Those are already (accidentally) being added in #24

@soruh
Copy link
Contributor

soruh commented Jan 24, 2020

I'd like to take a crack at implementing reserve.

@jonhoo
Copy link
Owner Author

jonhoo commented Jan 24, 2020

@soruh all yours!

@danielSanchezQ
Copy link
Contributor

I can give a try to the retain method 😄

@soruh
Copy link
Contributor

soruh commented Jan 25, 2020

I took a quick look at drain and into_iter in #33, but I'm not sure how correct & efficient what I wrote actually is.

@jonhoo jonhoo removed the good first issue Good for newcomers label Jan 29, 2020
@soruh
Copy link
Contributor

soruh commented Jan 29, 2020

@jonhoo I'd appreciate it if you could mark the drain and IntoIter impls as open (maybe with a link to my existing work); I don't really have the time to look into this further at the moment (I'm still open for questions about my initial implementation #33). I'll write another comment if I have the time to work on this and no one already has.

@jonhoo jonhoo added this to the 1.0 milestone Jan 31, 2020
@jonhoo
Copy link
Owner Author

jonhoo commented Feb 17, 2020

I'm replacing this with #62 now that there's just one item left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants