-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Eq and Debug traits #21
Implement Eq and Debug traits #21
Conversation
Codecov Report
|
I think it would be good to call out in the documentation (probably under "Consistency") the fact that checking for map equality might yield weird results if the map is being concurrently modified! |
Tests are failing because the len check is missing in PartialEq trait |
I recreated your idea here and it doesn't work. |
I will just leave it as it is and we can implement it later if possible. |
Ah, that is too bad. Well, since the current |
Okay. I will just add Debug impl too |
Excellent, thank you! |
This pr implements the
PartialEq
,Eq
and theDebug
traits.These additions were requested in #10