-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: small quick freeze modal adaptions #847
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ca07c23
fix: do not close quick freeze modal while loading
theborakompanioni a9f5842
fix: remove width of Confirmations component
theborakompanioni 288fd98
ui(send): monospace font for addresses
theborakompanioni 9b752d7
ui(send): add description to UTXOs section in confirm modal
theborakompanioni e15e1da
ui(send): proper label for UTXOs on sweeps
theborakompanioni 766a0ff
ui(send): improve phrasing in Quick Freeze and Confirm modal
theborakompanioni 0abf65b
send(ui): align confirmation block with divider toggle button
theborakompanioni 3f738c4
review(send): plural for utxo label in Payment Confirm Modal
theborakompanioni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,7 @@ | ||
.confirmations { | ||
width: 2rem; | ||
display: flex; | ||
flex-direction: column; | ||
justify-content: center; | ||
align-items: center; | ||
padding: 0.1rem 0.2rem; | ||
border-radius: 0.2rem; | ||
font-size: 0.75rem; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the matching with the subtitle_other, but it reads a bit weird imo "is eligible for inclusion" as it will for sure be included,
maybe something like
The selected UTXO will be used in the transaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I open to any suggestion. However, doesn't
sound more like it will "definitely used" in the transaction than the other phrase ("eligible for inclusion")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh.. okay. Now I think I get what you mean. If only one UTXO is selected, it will of course be included, yes?
Good point! I am not sure if the phrasing should change so "suddenly" when a user ticks some boxes in this component as it is just for quickly freezing/unfreezing..
I think @editwentyone might have good inputs to this also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarnixCroes I can't tell right now what is the best way, I would try to avoid the switching during selecting. lets see when we keep it like this first and then we can adjust it in another PR if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarnixCroes Okay for you if it is merged the way it is currently?
I think it the context of "quickly freezing/unfreezing UTXOs", phrasing it this way is "okay".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MarnixCroes - if it is okay for you, I'll merge this soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I missed this.
yes sure it's ok