-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: small quick freeze modal adaptions #847
Conversation
711c8be
to
288fd98
Compare
ping @editwentyone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"text_select_utxos_tooltip": "Select UTXOs", | ||
"title": "Select eligible UTXOs", | ||
"subtitle_zero": "Please select one or more UTXOs for possible inclusion in the transaction.", | ||
"subtitle_one": "The selected UTXO is eligible for inclusion in the transaction.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the matching with the subtitle_other, but it reads a bit weird imo "is eligible for inclusion" as it will for sure be included,
maybe something like The selected UTXO will be used in the transaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I open to any suggestion. However, doesn't
The selected UTXO will be used in the transaction.
sound more like it will "definitely used" in the transaction than the other phrase ("eligible for inclusion")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh.. okay. Now I think I get what you mean. If only one UTXO is selected, it will of course be included, yes?
Good point! I am not sure if the phrasing should change so "suddenly" when a user ticks some boxes in this component as it is just for quickly freezing/unfreezing..
I think @editwentyone might have good inputs to this also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarnixCroes I can't tell right now what is the best way, I would try to avoid the switching during selecting. lets see when we keep it like this first and then we can adjust it in another PR if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarnixCroes Okay for you if it is merged the way it is currently?
I think it the context of "quickly freezing/unfreezing UTXOs", phrasing it this way is "okay".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MarnixCroes - if it is okay for you, I'll merge this soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I missed this.
yes sure it's ok
Yep! Done! Thank you 🙏 |
This PR tries to enhance the phrasing in the Quick Freeze and Payment Confirm modal on the Send page.
Distinction is done between "Eligible UTXOs" (for non-sweeps) and "Selected UTXOs" (for sweeps).
Please let me know what you think - feedback is desperately needed!
Also, if you have better versions of the texts and phrases in mind - please post them here as comment or as change suggestion! 🙏
Quick Freeze Confirm Modal
"Select UTXOs to be considered"
to just"Select UTXOs"
"The following UTXOs are considered in the transaction. "
to one of the following"Every unselected UTXO will be frozen and can be unfrozen later on."
to"Unselected UTXOs will be frozen and can be unfrozen later anytime."
Payment Confirm Modal
"Considered UTXOs""Eligible UTXOs"
"One or more of the following UTXOs will be included in the transaction: "
"Selected UTXOs"
"The following UTXO will be included in the transaction: "
(single UTXO)"The following UTXOs will be included in the transaction: "
(multple UTXOs)📸 Screenshots (already outdated)