fix(#225): 24-hour binary clock #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obeys the users wish to display a 24h binary clock.
Closed
jkuester
approved these changes
Mar 23, 2024
There was a problem hiding this comment.
With your original implementation, the clock format would not get updated when the time format was set to "Follow system settings" and the user changes their system time format. Detecting the change in the system settings required tapping into the updateClock flow, but allowed me to centralize the logic back in BinaryClockView, which was nice.
jkuester
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obeys the users wish to display a 24h binary clock.
Fixes #225