Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24-hour binary clock #225

Closed
EGYT5453 opened this issue Mar 13, 2024 · 2 comments · Fixed by #229
Closed

24-hour binary clock #225

EGYT5453 opened this issue Mar 13, 2024 · 2 comments · Fixed by #229

Comments

@EGYT5453
Copy link

EGYT5453 commented Mar 13, 2024 •
edited
Loading

Problem?

There are only 4 "hour" bits, which is not enough for encoding 24-hour clock ( (2 ^ 4) - 1 = 15; 15 < 23)

My solution?

Add another bit, like here:
A 24-hour binary clock, with 5 bits
BBCLCD, CC BY-SA 4.0 https://creativecommons.org/licenses/by-sa/4.0, via Wikimedia Commons
@khwolf
Copy link

khwolf commented Mar 14, 2024

Setting time format to 24 hours should work...

khwolf added a commit to khwolf/unlauncher that referenced this issue Mar 14, 2024
@khwolf
Fix jkuester#225 24-hour binary clock
6e4bc72 
Obeys the users wish to display a 24h binary clock.
@khwolf
Copy link

khwolf commented Mar 14, 2024

... but does not. Sorry and thanks for noticing!
Fixed with #229

@jkuester jkuester mentioned this issue Mar 23, 2024
Merged
jkuester added a commit that referenced this issue Mar 23, 2024
@khwolf @jkuester
fix(#225): 24-hour binary clock (#229)
fdd08a5 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#225): 24-hour binary clock khwolf/unlauncher
2 participants
@khwolf @EGYT5453