Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "instance" object and use it for instance name propagation #77

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Add new "instance" object and use it for instance name propagation #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions schemas/2.2/example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"version": "2.2",
"instance": {
"name": "New FI𝑓F"
},
"software": {
"name": "diaspora",
"version": "0.5.0",
Expand Down
13 changes: 13 additions & 0 deletions schemas/2.2/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"additionalProperties": false,
"required": [
"version",
"instance",
"software",
"protocols",
"services",
Expand All @@ -21,6 +22,18 @@
"2.2"
]
},
"instance":{
"description": "Metadata specific to the instance. An instance is a the concrete installation of a software running on a server.",
Copy link
Contributor

@pfefferle pfefferle Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo An instance is a the concrete [...]!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, sorry, mind opening a follow up? 😇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh sorry I'm bad at typos too 😓

We migt at cSpell linter?

PS: @pfefferle if you want just open a pull ❤️

"type": "object",
"additionalProperties": false,
"properties": {
"name": {
"description": "If supported by the software the administrator configured name of this instance",
"type": "string",
"pattern": "^.{0,500}$"
}
}
},
"software": {
"description": "Metadata about server software in use.",
"type": "object",
Expand Down
Loading