Add new "instance" object and use it for instance name propagation #77
Conversation
about limit lengththe-federation.info database has this: select node.domain,LENGTH(d::text) as l from (select node_id,data->'metadata'->'nodeName'::text as d from node_info where data->'metadata'->'nodeDescription' IS NOT NULL) JOIN node on node.id=node_id order by l desc limit 30; |
|
|
I propose limit of 500 , so #78 would be exactly 10x |
|
@jhass request your comments :) |
|
@jhass added max length of 500 to it |
There was a problem hiding this comment.
While the instance.name property itself should obviously be optional, I'd actually favor to make the instance object itself mandatory. That is I think it would be preferable for an instance without a configured name to expose "instance": {} or "instance: { "name": null } always, such that a client who validated the response against the schema can be sure to always have an object at instance and save a null check.
Co-authored-by: Jonne Haß <[email protected]>
|
squash-merged your changes and made instance required |
| @@ -21,6 +22,18 @@ | |||
| "2.2" | |||
| ] | |||
| }, | |||
| "instance":{ | |||
| "description": "Metadata specific to the instance. An instance is a the concrete installation of a software running on a server.", | |||
There was a problem hiding this comment.
There is a typo An instance is a the concrete [...]!
There was a problem hiding this comment.
Ups, sorry, mind opening a follow up? 😇
There was a problem hiding this comment.
Uh sorry I'm bad at typos too 😓
We migt at cSpell linter?
PS: @pfefferle if you want just open a pull ❤️
move wily used
nodeNameinto the normal spec.this also should contain more instance configured specific information.