#334 - fix log message pattern to include parameter index

src/main/java/io/jenkins/plugins/bitbucketpushandpullrequest/client/BitBucketPPRClientCloudVisitor.java

@@ -60,16 +60,16 @@
         logger.log(Level.FINEST, "Result of the status notification is: {0}, with status code: {1}",
             new Object[] {responseBody, response.getStatusLine().getStatusCode()});
       } catch (IOException e) {
-        logger.log(Level.WARNING, "Error during state notification: {} ", e.getMessage());
+        logger.log(Level.WARNING, "Error during state notification: {0} ", e.getMessage());
       }
     else if (credentials instanceof StringCredentials) {
       try {
         Response response = this.send((StringCredentials) credentials, verb, url, payload);
 
         logger.log(Level.FINEST, "Result of the state notification is: {0}, with status code: {1}",
             new Object[] {response.getBody(), response.getCode()});
       } catch (ExecutionException | IOException e) {
-        logger.log(Level.WARNING, "Error during state notification: {} ", e.getMessage());
+        logger.log(Level.WARNING, "Error during state notification: {0} ", e.getMessage());
       } catch (InterruptedException e) {
         throw e;
       }

src/main/java/io/jenkins/plugins/bitbucketpushandpullrequest/client/BitBucketPPRClientServerVisitor.java

@@ -63,17 +63,17 @@
         logger.log(Level.FINEST, "Result of the status notification is: {0}, with status code: {1}",
             new Object[] {responseBody, response.getStatusLine().getStatusCode()});
       } catch (IOException e) {
-        logger.log(Level.WARNING, "Error during state notification: {} ", e.getMessage());
+        logger.log(Level.WARNING, "Error during state notification: {0} ", e.getMessage());
       }
     else if (credentials instanceof StringCredentials)
       try {
         HttpResponse response = this.send((StringCredentials) credentials, verb, url, payload);
         logger.log(Level.FINEST, "Result of the state notification is: {0}, with status code: {1}",
             new Object[] {response.getEntity().getContent(),
                 response.getStatusLine().getStatusCode()});
       } catch (ExecutionException | IOException | KeyManagementException | NoSuchAlgorithmException
           | KeyStoreException e) {
-        logger.log(Level.WARNING, "Error du" + "ring state notification: {} ", e.getMessage());
+        logger.log(Level.WARNING, "Error du" + "ring state notification: {0} ", e.getMessage());
       } catch (InterruptedException e) {
         throw e;
       }

src/main/java/io/jenkins/plugins/bitbucketpushandpullrequest/common/BitBucketPPRUtils.java

@@ -89,7 +89,7 @@ public static boolean matchWithRegex(@Nonnull String haystack, @Nonnull String p
     }
 
     if (patternStr == null || patternStr.trim().isEmpty()) {
-      logger.fine(String.format("The regex filter on the comment from BB is null or it is empty", new Object[] {}));
+      logger.fine("The regex filter on the comment from BB is null or it is empty");
       return true;
     }
 

src/main/java/io/jenkins/plugins/bitbucketpushandpullrequest/observer/BitBucketPPRHandlerTemplate.java

@@ -90,21 +90,21 @@
       String jsonPayload = objectMapper.writeValueAsString(payload);
       BitBucketPPRClientFactory.createClient(clientType, context).send(url, jsonPayload);
     } catch (JsonProcessingException e) {
-      logger.log(Level.WARNING, "Cannot create payload: {}", e.getMessage());
+      logger.log(Level.WARNING, "Cannot create payload: {0}", e.getMessage());
     } catch (Exception e) {
       logger.warning(e.getMessage());
     }
   }
 
   protected void callClient(@Nonnull Verb verb, @Nonnull String url,
       @Nonnull Map<String, String> payload) {
     ObjectMapper objectMapper = new ObjectMapper();
 
     try {
       String jsonPayload = payload.isEmpty() ? "" : objectMapper.writeValueAsString(payload);
       BitBucketPPRClientFactory.createClient(clientType, context).send(verb, url, jsonPayload);
     } catch (JsonProcessingException e) {
-      logger.log(Level.WARNING, "Cannot create payload: {}", e.getMessage());
+      logger.log(Level.WARNING, "Cannot create payload: {0}", e.getMessage());
     } catch (Exception e) {
       logger.warning(e.getMessage());
     }

src/main/java/io/jenkins/plugins/bitbucketpushandpullrequest/observer/BitBucketPPRObserverFactory.java

@@ -43,28 +43,28 @@
 
     if (REPOSITORY_EVENT.equalsIgnoreCase(bitbucketEvent.getEvent())
         && REPOSITORY_CLOUD_PUSH.equalsIgnoreCase(bitbucketEvent.getAction())) {
-      logger.log(Level.FINE, "Add BitBucketPPRPushCloudObserver for {}", bitbucketEvent);
+      logger.log(Level.FINE, "Add BitBucketPPRPushCloudObserver for {0}", bitbucketEvent);
       observable.addObserver(new BitBucketPPRPushCloudObserver());
     }
 
     if (REPOSITORY_EVENT.equalsIgnoreCase(bitbucketEvent.getEvent())
         && REPOSITORY_SERVER_PUSH.equalsIgnoreCase(bitbucketEvent.getAction())) {
-      logger.log(Level.FINE, "Add BitBucketPPRPushServerObserver for {}", bitbucketEvent);
+      logger.log(Level.FINE, "Add BitBucketPPRPushServerObserver for {0}", bitbucketEvent);
       observable.addObserver(new BitBucketPPRPushServerObserver());
     }
 
     if (PULL_REQUEST_CLOUD_EVENT.equals(bitbucketEvent.getEvent())) {
-      logger.log(Level.FINE, "Add BitBucketPPRPullRequestCloudObserver for {}", bitbucketEvent);
+      logger.log(Level.FINE, "Add BitBucketPPRPullRequestCloudObserver for {0}", bitbucketEvent);
       observable.addObserver(new BitBucketPPRPullRequestCloudObserver());
     }
 
     if (PULL_REQUEST_SERVER_EVENT.equals(bitbucketEvent.getEvent())) {
-      logger.log(Level.FINE, "Add BitBucketPPRPullRequestServerObserver for {}", bitbucketEvent);
+      logger.log(Level.FINE, "Add BitBucketPPRPullRequestServerObserver for {0}", bitbucketEvent);
       observable.addObserver(new BitBucketPPRPullRequestServerObserver());
     }
 
     if (observable.getObservers().isEmpty())
-      logger.log(Level.FINE, "No observer found for the observable of event {}", bitbucketEvent);
+      logger.log(Level.FINE, "No observer found for the observable of event {0}", bitbucketEvent);
 
     return observable;
   }