Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#334 - fix log message pattern to include parameter index #335

Merged

Conversation

Gozke
Copy link
Contributor

@Gozke Gozke commented Jul 6, 2024

This is my fix for issue #334.
I did a string search for {} and fixed the relevant occurences one by one.

Testing done

I created locally a log config to dump everything to the console and ran a few unit tests that were known to create the problematic log messages.
My src/test/resources/logging.properties file looked like this:

handlers=java.util.logging.ConsoleHandler
.level=ALL
java.util.logging.ConsoleHandler.level = ALL
java.util.logging.ConsoleHandler.formatter = java.util.logging.SimpleFormatter

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@cdelmonte-zg cdelmonte-zg merged commit bcc7cda into jenkinsci:master Aug 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants