Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privatek8s: track JDK tool installations with updatecli + bump JDK8, JDK11 and JDK17 to latest available version #4634

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 6, 2023

Related to jenkins-infra/helpdesk#3783, this PR adds updatecli manifests to track the JDK tool installation versions for JDK8, JDK11, JDK17 and JDK21.

To test the manifest, I've used it to update locally:

  • JDK8 to 8u392-b08 (updatecli apply without scmid in targets)
  • JDK11 to 11.0.16.1+1 (updatecli apply without scmid in targets)
  • JDK17 to 17.0.8.1+1 ( Custom source + updatecli apply without scmid in targets) => this is the last version with x64_windows in the same version as Linux

Note: JDK21 is already up to date since #4629

Note 2: updatecli/updatecli#1733 would help to simplify the manifests here A LOT

Copy link
Contributor

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dduportal dduportal merged commit 5dc0507 into jenkins-infra:main Nov 6, 2023
6 checks passed
@dduportal dduportal deleted the chore/updatecli/track-jdk-tool-installations branch November 6, 2023 13:38
@dduportal
Copy link
Contributor Author

Tested with success once deployed with the following pipeline in a replay:

parallel linuxamd64vm: {
    node('linux-amd64-docker') {
        infra.runMaven(['-v'], 8)
        infra.runMaven(['-v'], 11)
        infra.runMaven(['-v'], 17)
        infra.runMaven(['-v'], 21)
    }
},
linuxarm64vm: {
    node('linux-arm64-docker') {
        infra.runMaven(['-v'], 8)
        infra.runMaven(['-v'], 11)
        infra.runMaven(['-v'], 17)
        infra.runMaven(['-v'], 21)
    }
},
windowsamd64vm: {
    node('docker-windows-2019') {
        infra.runMaven(['-v'], 8)
        infra.runMaven(['-v'], 11)
        infra.runMaven(['-v'], 17)
        infra.runMaven(['-v'], 21)
    }
}

@dduportal
Copy link
Contributor Author

This PR broke the updatecli process though:

✗ Bump JDK8 version (Jenkins tools) on all controllers:
  	Source:
  		✔ [escapedVersion] 
  		✔ [lastVersion] Get the latest Adoptium JDK8 version
  	Condition:
  		✔ [checkIfReleaseIsAvailable] 
  	Target:
  		✔ [setJDK8Subdir] Bump JDK8 version on tools
  		✗ [setJDK8UrlFilenames] Bump JDK8 version on tools
  		✔ [setJDK8UrlPaths] Bump JDK8 version on tools

and

  ✗ Bump JDK11 version (Jenkins tools) on all controllers:
  	Source:
  		✔ [escapedVersion] 
  		✔ [lastVersion] 
  	Condition:
  		✔ [checkIfReleaseIsAvailable] 
  	Target:
  		✔ [setJDK11Subdir] Bump JDK11 version on tools
  		✗ [setJDK11UrlFilenames] Bump JDK11 version on tools
  		✔ [setJDK11UrlPaths] Bump JDK11 version on tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants