-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privatek8s: track JDK tool installations with updatecli
+ bump JDK8, JDK11 and JDK17 to latest available version
#4634
Merged
dduportal
merged 4 commits into
jenkins-infra:main
from
dduportal:chore/updatecli/track-jdk-tool-installations
Nov 6, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
…6.1+1 Signed-off-by: Damien Duportal <[email protected]>
….1+1 Signed-off-by: Damien Duportal <[email protected]>
smerle33
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Tested with success once deployed with the following pipeline in a replay:
|
This PR broke the updatecli process though:
and
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#3783, this PR adds updatecli manifests to track the JDK tool installation versions for JDK8, JDK11, JDK17 and JDK21.
To test the manifest, I've used it to update locally:
8u392-b08
(updatecli apply
withoutscmid
in targets)11.0.16.1+1
(updatecli apply
withoutscmid
in targets)17.0.8.1+1
( Custom source +updatecli apply
withoutscmid
in targets) => this is the last version with x64_windows in the same version as LinuxNote: JDK21 is already up to date since #4629
Note 2: updatecli/updatecli#1733 would help to simplify the manifests here A LOT