feat-logger-update

[nguyenhoangthuan99]

Fixes #1153

[nguyenhoangthuan99]

• separate log file for cortex.log and cortex-cli.log
• pruning log file only to save last 100,000 lines. The log file will be truncated if number of line > max_lines. Check if file will be truncated every 1000 new lines.
• configurable log file location. Save the config in the ~/.cortexrc

logFolderPath: C:\Users\jan\cortexcpp
dataFolderPath: C:\Users\jan\cortexcpp
host: 127.0.0.1
port: 3928

[dan-homebrew]

@nguyenhoangthuan99 Please link this PR to issue via keyword - I've helped to do this in the Description

[dan-homebrew]

@nguyenhoangthuan99 A few questions:

• Do we have a filesize estimate of how much space 100,000 log lines will equate to?
• Should we make num log lines a variable in .cortexrc that users can configure? (need to find a good variable name for this)

I imagine cortex.cpp may have some embedded use-cases in the future, where devs may have diskspace constraints for logs (difficult for me to imagine now with >1gb model sizes, but this may change in the future)

[nguyenhoangthuan99]

Hi @dan-homebrew , Average each line will contains < 300 characters , each character is 1 byte. So 100,000 lines will be 300 * 100,000/(1024*1024) ~ 30Mb

[dan-homebrew]

Hi @dan-homebrew , Average each line will contains < 300 characters , each character is 1 byte. So 100,000 lines will be 300 * 100,000/(1024*1024) ~ 30Mb

This looks good to me - let's include it as a default param in .cortexrc

[dan-homebrew]

Lgtm

[dan-homebrew]

Great job!