Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error on invalid ref config #186

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: return error on invalid ref config #186

merged 1 commit into from
Oct 22, 2024

Conversation

jahvon
Copy link
Owner

@jahvon jahvon commented Oct 22, 2024

This "fixes" a panic that happens if the cmd or ref isn't defined for a serial or parallel exec

This "fixes" a panic that happens if the cmd or ref isn't defined for
a serial or parallel exec
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.62%. Comparing base (fd5bbc7) to head (61dfbb9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/runner/parallel/parallel.go 0.00% 2 Missing ⚠️
internal/runner/serial/serial.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   34.64%   34.62%   -0.03%     
==========================================
  Files          81       81              
  Lines        6742     6746       +4     
==========================================
  Hits         2336     2336              
- Misses       3968     3974       +6     
+ Partials      438      436       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahvon jahvon merged commit aca34bf into main Oct 22, 2024
10 checks passed
@jahvon jahvon deleted the fix-panic branch October 22, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant