fix: return error on invalid ref config

This "fixes" a panic that happens if the cmd or ref isn't defined for a serial or parallel exec
jahvon · Oct 22, 2024 · aca34bf · aca34bf
1 parent fd5bbc7
commit aca34bf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/internal/runner/parallel/parallel.go b/internal/runner/parallel/parallel.go
@@ -70,6 +70,8 @@ func handleExec(
 			}
 		case refConfig.Cmd != "":
 			exec = execUtils.ExecutableForCmd(parent, refConfig.Cmd, i)
+		default:
+			return errors.New("parallel executable must have a ref or cmd")
 		}
 
 		execPromptedEnv := make(map[string]string)

diff --git a/internal/runner/serial/serial.go b/internal/runner/serial/serial.go
@@ -63,6 +63,8 @@ func handleExec(
 			}
 		case refConfig.Cmd != "":
 			exec = execUtils.ExecutableForCmd(parent, refConfig.Cmd, i)
+		default:
+			return errors.New("serial executable must have a ref or cmd")
 		}
 		ctx.Logger.Debugf("executing %s (%d/%d)", exec.Ref(), i+1, len(serialSpec.Execs))