Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pressure_odometry_node.py #62

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Update pressure_odometry_node.py #62

wants to merge 9 commits into from

Conversation

optimistprime21
Copy link

@optimistprime21 optimistprime21 commented Nov 2, 2024 •
edited by ozanhakantunca
Loading

Closes #70

Adjusted the sensor offset for bar30. It now transforms depth data from the pressure sensor into the base link's frame.

senceryazici
senceryazici reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@senceryazici senceryazici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but we need to make sure the tf loopback wouldn't be a problem.

@senceryazici senceryazici force-pushed the sila/pressure_to_odom branch 2 times, most recently from bcf9327 to 9e6697a Compare November 23, 2024 13:30
@senceryazici senceryazici added the needs hardware test features that needs to be tested on the hardware label Nov 23, 2024
senceryazici
senceryazici previously approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@senceryazici senceryazici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in terms of coding, but still need to pass hardware test.

optimistprime21 and others added 2 commits December 10, 2024 23:44
@optimistprime21
Update pressure_odometry_node.py
9b7f1b3 
Adjusted the sensor offset for bar30.
@optimistprime21
Merge branch 'sila/pressure_to_odom' of github.com:itu-auv/auv-softwa…
562c88c 
…re into sila/pressure_to_odom
@ozanhakantunca ozanhakantunca added needs simulation test Features that needs to be tested on the simulation needs hardware test features that needs to be tested on the hardware and removed needs hardware test features that needs to be tested on the hardware labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senceryazici senceryazici senceryazici left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs hardware test features that needs to be tested on the hardware needs simulation test Features that needs to be tested on the simulation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adjust sensor offset for bar30
3 participants
@optimistprime21 @senceryazici @ozanhakantunca