Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix align frame controller still executing when smach is killed #104

Open
eminmeydanoglu opened this issue Dec 21, 2024 · 0 comments · May be fixed by #105
Open

Fix align frame controller still executing when smach is killed #104

eminmeydanoglu opened this issue Dec 21, 2024 · 0 comments · May be fixed by #105
Labels
bug Something isn't working needs hardware test features that needs to be tested on the hardware

Comments

@eminmeydanoglu
Copy link

eminmeydanoglu commented Dec 21, 2024

Sometimes we kill the state machine mid task. At such times, some command velocity is still published by align frame controller. Not sure what the align frame controller tries to align to, maybe the frame it was trying to align itself before the smach is killed. But there were times I observed the robot moves at random and unexpected places, which might suggest the robot is trying to align somewhere else, or (x) there is some other bug causing the unwanted behaviour.

Whatever, the point is that when the smach is killed, we don't want to align anywhere apart from our current position. So we can either;

  1. Call the disable service of align frame controller
  2. Or align to taluy/base_link. Then there is no error, and cmd_vel is 0.
    when we kill the smach. (We can use ctrl+c as the trigger)

I think the second option is more plausible. And this will probably solve the problem of unexpected behaviour (if x is not true)

@eminmeydanoglu eminmeydanoglu added bug Something isn't working needs hardware test features that needs to be tested on the hardware labels Dec 21, 2024
@talhabw talhabw linked a pull request Dec 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs hardware test features that needs to be tested on the hardware
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant