Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close cooperation process #2900

Merged
merged 17 commits into from
Dec 4, 2024
Merged

Conversation

nebby2105
Copy link
Contributor

@nebby2105 nebby2105 commented Nov 27, 2024

Implemented functionality:

  1. Added the ability for a student to initiate the cooperation closing process by clicking the Close cooperation button
  2. Implemented a confirmation modal that appears when the Close cooperation button is clicked
  3. Updated logic to handle cooperation status changes:
  • Set status to Request to close after the student confirms the action.
  • Set status to Closed after the responsible user accepts the request.
  1. Added a Cooperation closing process block in the Activities tab for users whose role matches the needAction field

Click Close cooperation →
Screenshot 2024-11-27 at 20 45 50

A confirmation modal is displayed →
Screenshot 2024-11-27 at 20 54 39

Confirm by clicking Yes → Cooperation status changes to Request to close:
Screenshot 2024-11-27 at 20 54 54

User whose role is equal to needAction field sees Cooperation closing process block in the Activities tab:
Screenshot 2024-11-27 at 20 55 04

Clicking Accept updates the cooperation status to Closed:
Screenshot 2024-11-27 at 20 55 11

  • Add functionality to allow students to initiate the cooperation closing process.
  • Update cooperation status to Request to close and Closed.
  • Implement Cooperation closing process block in the Activities tab.

<Box>
<Box sx={styles.title}>
<ErrorOutlineRounded />
<Typography>Cooperation closing process</Typography>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be better to use text from useTranslation hook instead of hardcoding it ( and everywhere you don't use useTranslation hook )

Copy link
Contributor

@ShadowOfTheSpace ShadowOfTheSpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but change this || to ?? if you can, please)

Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
79.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@nebby2105 nebby2105 merged commit b2b6410 into develop Dec 4, 2024
9 of 10 checks passed
@nebby2105 nebby2105 deleted the feature/2644/close-cooperation-process branch December 4, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SP: 2) Close cooperation process
4 participants