-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close cooperation process #2900
Conversation
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.styles.ts
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.styles.ts
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.styles.ts
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-completion/CooperationCompletion.tsx
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-completion/CooperationCompletion.styles.ts
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-details/CooperationDetails.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-details/CooperationDetails.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-details/CooperationDetails.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/my-cooperations-details/MyCooperationsDetails.tsx
Outdated
Show resolved
Hide resolved
<Box> | ||
<Box sx={styles.title}> | ||
<ErrorOutlineRounded /> | ||
<Typography>Cooperation closing process</Typography> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be better to use text from useTranslation hook instead of hardcoding it ( and everywhere you don't use useTranslation hook )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but change this ||
to ??
if you can, please)
src/containers/my-cooperations/cooperation-details/CooperationDetails.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-details/CooperationDetails.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-details/CooperationDetails.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-completion/CooperationCompletion.tsx
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
Implemented functionality:
Close cooperation
buttonRequest to close
after the student confirms the action.Closed
after the responsible user accepts the request.Cooperation closing process
block in theActivities
tab for users whose role matches theneedAction
fieldClick Close cooperation →
A confirmation modal is displayed →
Confirm by clicking Yes → Cooperation status changes to
Request to close
:User whose role is equal to
needAction
field seesCooperation closing process
block in the Activities tab:Clicking
Accept
updates the cooperation status toClosed
:Request to close
andClosed
.Cooperation closing process
block in the Activities tab.