Refactor reviews endpoints for correct data flow #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
luiqor
requested review from
dudchakk,
ShadowOfTheSpace,
sandrvvu,
Mav-Ivan,
Mike-Popovych and
RomanRozbytskyi
Mav-Ivan
approved these changes
Dec 3, 2024
ShadowOfTheSpace
approved these changes
Dec 3, 2024
RomanRozbytskyi
approved these changes
Dec 4, 2024
luiqor
force-pushed
the
bugfix/1020/refactor-reviews-endpoint-data-flow
branch
from
e845177 to
ce99c4b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GET /reviews/ to support fetching reviews by targetUserId.
../reviews?role=tutor&user=673615d36b214652201af558)Correct the logic to ensure only a single proficiencyLevel value is returned from cooperation instead of array from offer.
The review design incorporates a
profiency levelfrom cooperation, rather than including an array of all levels from the offer. However, review should have reference to Offer to be able to redirect interested person to offer instead of certain cooperation.Before:
After:
Correct recalculation of user review stats to be automatic on POST /reviews/, PATCH, DELETE.
stat-recalculation-on-edit.mp4
Add validation schemas
Update review docs