Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SP: 3) Refactor reviews endpoints for correct data handling and flow #1020

Closed
4 tasks done
luiqor opened this issue Nov 30, 2024 · 0 comments · Fixed by #1021
Closed
4 tasks done

(SP: 3) Refactor reviews endpoints for correct data handling and flow #1020

luiqor opened this issue Nov 30, 2024 · 0 comments · Fixed by #1021
Assignees
@luiqor
Labels
Backend

Comments

@luiqor
Copy link
Contributor

luiqor commented Nov 30, 2024 •
edited
Loading

Reviews will be used in the cooperation closure process.

  • Fix GET /reviews/ to support fetching reviews by targetUserId.
  • Correct the logic to ensure only a single proficiencyLevel value is returned from cooperation instead of array from offer.
  • Add automatic recalculation of stats on POST /reviews/, PATCH, DELETE.
  • Remove the unnecessary /reviews/stats endpoint (as stats will be recalculated automatically with POST /reviews/)
@luiqor luiqor self-assigned this Nov 30, 2024
@luiqor luiqor converted this from a draft issue Nov 30, 2024
@luiqor luiqor added the Backend label Nov 30, 2024
@luiqor luiqor linked a pull request Dec 1, 2024 that will close this issue
Refactor reviews endpoints for correct data flow #1021
Merged
@luiqor luiqor moved this from Sprint Backlog to Merge request in SpaceToStudy Dec 2, 2024
@luiqor luiqor changed the title Refactor reviews endpoints for correct data handling and flow (SP: 3) Refactor reviews endpoints for correct data handling and flow Dec 2, 2024
@github-project-automation github-project-automation bot moved this from Merge request to Done in SpaceToStudy Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luiqor luiqor

Labels
Backend
Projects
SpaceToStudy
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor reviews endpoints for correct data flow ita-social-projects/SpaceToStudy-BackEnd
1 participant
@luiqor