DFCxx kernel instantiation #52
Conversation
Muxianesty
added
enhancement
src/model/dfcxx/include/dfcxx/io.h
Outdated
| @@ -28,6 +28,10 @@ class IO { | |||
|
|
|||
| DFVariable inputScalar(const std::string &name, const DFType &type); | |||
|
|
|||
| DFVariable hollow(const DFType &type); | |||
There was a problem hiding this comment.
What is "hollow" synonym here? What does this method do exactly?
There was a problem hiding this comment.
It's an unconnected node without specific operation behind it. Currently it can only be used to be bound to another kernel's output. By the end of kernel's construction there mustn't be any nodes like that.
There was a problem hiding this comment.
hollow -> unconnected?
hollow -> dummy?
It would be good to have more describing name for the method here
There was a problem hiding this comment.
I get it, but Unconnected - too long; Dummy - too confusing. I am going to check MaxCompiler docs on how they call such things.
UPD: MaxCompiler has DFEType::newInstance methods which do the same. I do not want to associate this functionality (at least now) with types, and instead treat them as kernel methods. Perhaps just newStream and newScalar?
There was a problem hiding this comment.
Yeah, newStream and newScalar look better
src/model/dfcxx/lib/dfcxx/graph.cpp
Outdated
| if (it->target == output) { | ||
| if (target.type == OpType::NONE) { | ||
| outs.erase(it); | ||
| for (auto &out: outputs[target]) { | ||
| for (auto &in: inputs[out.target]) { | ||
| if (in.source == target && out == in) { | ||
| in.source = it->source; | ||
| outs.push_back(in); | ||
| } | ||
| } | ||
| auto conIt = connections.find(out.target); | ||
| if (conIt != connections.end() && conIt->second.source == target) { | ||
| conIt->second.source = it->source; | ||
| } | ||
| } | ||
| target = it->source; | ||
| } else { | ||
| it->target = target; | ||
| inputs[target].clear(); | ||
| inputs[target].push_back(*it); | ||
| connections[target] = *it; | ||
| } | ||
| break; | ||
| } |
There was a problem hiding this comment.
This code fragment is too "nesting". Please decrease it, using "continue" operator inside loop, etc.
No description provided.