DOT output format #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muxianesty
added
enhancement
ssmolov
reviewed
Aug 19, 2024
README.md
Outdated
| @@ -221,6 +221,7 @@ The list of arguments for `hls`-mode is presented below: | |||
| * `--out-sv-lib <PATH>`: *optional* filesystem-path option; used to specify the output SystemVerilog file for generated operations library. | |||
| * `--out-dfcir <PATH>`: *optional* filesystem-path option; used to specify the output DFCIR file. | |||
| * `--out-firrtl <PATH>`: *optional* filesystem-path option; used to specify the output FIRRTL file. | |||
| * `--out-dot <PATH>`: *optional* filesystem-path option; used to specify the output .dot file. | |||
There was a problem hiding this comment.
The following renaming is proposed:
".dot" -> "DOT"
It will look more relevant to existing descriptions in this file
src/model/dfcxx/lib/dfcxx/kernel.cpp
Outdated
| outputStreams, | ||
| sched); | ||
| bool result = true; | ||
| // Compile the kernel to .dot if such stream is specified. |
src/options.h
Outdated
| @@ -195,6 +197,9 @@ struct HlsOptions final : public AppOptions { | |||
| outputGroup->add_option(OUT_FIRRTL_ARG, | |||
| outNames[OUT_FORMAT_ID_INT(FIRRTL)], | |||
| "Path to output scheduled FIRRTL"); | |||
| outputGroup->add_option(OUT_DOT_ARG, | |||
| outNames[OUT_FORMAT_ID_INT(Dot)], | |||
| "Path to output a DFCxx kernel in .dot format."); | |||
ssmolov
reviewed
Aug 19, 2024
src/model/dfcxx/lib/dfcxx/kernel.cpp
Outdated
Comment on lines
19
to
20
| #include <unordered_map> | ||
| #include <string> |
There was a problem hiding this comment.
Lexicographical order is broken
ssmolov
approved these changes
Aug 19, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces
.dot-file output format for DFCxx dataflow graph, mentioned in #27.