Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP noise annotation refactor #69

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

WIP noise annotation refactor #69

wants to merge 57 commits into from

Commits on Aug 8, 2022

  1. Merge pull request isce-framework#3 from opera-adt/main 

    Updating the main branch of this fork to update after `s1_annotation.py`
    @seongsujeong
    seongsujeong authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    26213e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Merge branch 'main' of github.com:opera-adt/s1-reader

    Seongsu Jeong committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    8fddf15 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Replacing the loaders in Burst* class into class methods, with furthe… 

    …r implementation for thermal and EAP correction
    Seongsu Jeong committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    dffe813 View commit details
    Browse the repository at this point in the history

  2. fix on determining beta_naught; addressing PEP8 issues

    Seongsu Jeong committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    0ec4fc4 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2022

  1. Bug fix and feature addition to BurstEAP; restructuring LUT exportation

    Seongsu Jeong committed Aug 20, 2022
    Configuration menu
    Copy the full SHA
    b4d3c0e View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Readibility improvement; removing unnecessary imports

    Seongsu Jeong committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    6d11d3d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:opera-adt/s1-reader

    Seongsu Jeong committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    460eecb View commit details
    Browse the repository at this point in the history

  3. Format change on burst_id; keeping the absolute orbit number inside… 

    … `Sentinel1BurstSlc`
    Seongsu Jeong committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    142ece4 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. updates on test_bursts.py

    Seongsu Jeong committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    bae4227 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:opera-adt/s1-reader into burst_id_a… 

    …nd_abs_orbit
    Seongsu Jeong committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5eb971b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'burst_id_and_abs_orbit' into correction_and_calibration

    Seongsu Jeong committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    45662ce View commit details
    Browse the repository at this point in the history

  4. keeping the basename of the CADS and NADS for populating RTC metadata

    Seongsu Jeong committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    83454cb View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2022

  1. Update src/s1reader/s1_annotation.py 

    Readability improvement on equation

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    b29ffe2 View commit details
    Browse the repository at this point in the history

  2. Update src/s1reader/s1_annotation.py 

    Removing commented out code

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    2ae4fa2 View commit details
    Browse the repository at this point in the history

  3. Update src/s1reader/s1_annotation.py 

    Reverting the docstring to be split into two lines for PEP8 compliance

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    79a4f20 View commit details
    Browse the repository at this point in the history

  4. Update src/s1reader/s1_annotation.py 

    Improving docstring of the code copied from isce2

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    79032a4 View commit details
    Browse the repository at this point in the history

  5. Update src/s1reader/s1_burst_slc.py 

    Removing the commented out codes

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    de49003 View commit details
    Browse the repository at this point in the history

  6. Update src/s1reader/s1_burst_slc.py 

    improvement on code brevity

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    9013e4f View commit details
    Browse the repository at this point in the history

  7. Update src/s1reader/s1_burst_slc.py 

    renaming variable for better clarity

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    64f34e0 View commit details
    Browse the repository at this point in the history

  8. Update src/s1reader/s1_burst_slc.py 

    renaming variable name for clarity

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    e7df7b0 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #5 from opera-adt/main 

    Bump isce3 to 0.8 and refresh CI specfile (isce-framework#66)
    @seongsujeong
    seongsujeong authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    389aa53 View commit details
    Browse the repository at this point in the history

  10. Update src/s1reader/s1_burst_slc.py 

    variable name revised for clarity

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    bf029cc View commit details
    Browse the repository at this point in the history

  11. Update src/s1reader/s1_burst_slc.py 

    variable renamed for clarity

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    b3f3612 View commit details
    Browse the repository at this point in the history

  12. Update src/s1reader/s1_burst_slc.py 

    improvement on docstring

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    f0b0b82 View commit details
    Browse the repository at this point in the history

  13. Update src/s1reader/s1_burst_slc.py 

    Readability improvement of equation

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    4109740 View commit details
    Browse the repository at this point in the history

  14. addressing comments bt @LiangJYu

    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    6d62feb View commit details
    Browse the repository at this point in the history

  15. Merge branch 'correction_and_calibration' of github.com:seongsujeong/… 

    …s1-reader into correction_and_calibration
    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    df2b371 View commit details
    Browse the repository at this point in the history

  16. docstring fix; variables renamed for clarity

    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    1af92bf View commit details
    Browse the repository at this point in the history

  17. implemented s1_annotation.AucCal.load_from_zip_file()

    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    d9a76d9 View commit details
    Browse the repository at this point in the history

  18. readability improvement

    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    3504967 View commit details
    Browse the repository at this point in the history

  19. s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8… 

    … compliance
    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    6b2a07a View commit details
    Browse the repository at this point in the history

  20. docstring for s1_burst_slc.eap_compensation_lut()

    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    d5cd5de View commit details
    Browse the repository at this point in the history

  21. class import scheme changed

    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    db59419 View commit details
    Browse the repository at this point in the history

  22. PEP8 compliance

    Seongsu Jeong committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    e908892 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Update src/s1reader/s1_annotation.py 

    Renaming variable for clarity

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 31, 2022
    Configuration menu
    Copy the full SHA
    a9149e1 View commit details
    Browse the repository at this point in the history

  2. Update src/s1reader/s1_annotation.py 

    Fix on docstring for `s1_annotation.AuxCal.load_from_zip_file()`

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 31, 2022
    Configuration menu
    Copy the full SHA
    7fb70a4 View commit details
    Browse the repository at this point in the history

  3. Update src/s1reader/s1_annotation.py 

    Change on docstring for s1_annotation.BurstEAP._anx2height

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 31, 2022
    Configuration menu
    Copy the full SHA
    53ffce4 View commit details
    Browse the repository at this point in the history

  4. Update src/s1reader/s1_reader.py 

    updates on s1_reader.get_path_aux_cal()

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 31, 2022
    Configuration menu
    Copy the full SHA
    0700e74 View commit details
    Browse the repository at this point in the history

  5. Update src/s1reader/s1_reader.py 

    Readability improvement

Co-authored-by: Liang Yu <[email protected]>
    @seongsujeong @LiangJYu
    seongsujeong and LiangJYu authored Aug 31, 2022
    Configuration menu
    Copy the full SHA
    fe8252e View commit details
    Browse the repository at this point in the history

  6. command and variable name revised for clarity

    Seongsu Jeong committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    90c09bd View commit details
    Browse the repository at this point in the history

  7. Raise error when burst_noise is not defined but user attempts to re… 

    …trieve thermal correction LUT
    Seongsu Jeong committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d87c234 View commit details
    Browse the repository at this point in the history

  8. fixing variable names that causing CircieCI to fail

    Seongsu Jeong committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    08acee0 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. LUT retrieval scheme changed; updates in accordance with the comments… 

    … / suggestions from @Liang Yu
    Seongsu Jeong committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    27f6998 View commit details
    Browse the repository at this point in the history

  2. Changing the length unit in BurstEAP._anx2roll() to [m]

    Seongsu Jeong committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    637a7d5 View commit details
    Browse the repository at this point in the history

  3. change on variable name for clarity

    Seongsu Jeong committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    9c13a08 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Addressing PEP8 issue (R0201)

    Seongsu Jeong committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    265a6c2 View commit details
    Browse the repository at this point in the history

  2. Reverting the unit in _anx2roll() into the original documentataion;… 

    … Comment cleanup
    Seongsu Jeong committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    4aac153 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Update src/s1reader/s1_annotation.py 

    Clarification of the description

Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
    @seongsujeong @gshiroma
    seongsujeong and gshiroma authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    1b7f805 View commit details
    Browse the repository at this point in the history

  2. Update src/s1reader/s1_annotation.py 

    Clarification on docsctring

Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
    @seongsujeong @gshiroma
    seongsujeong and gshiroma authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    14e046c View commit details
    Browse the repository at this point in the history

  3. Update src/s1reader/s1_annotation.py 

    fix on docstring

Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
    @seongsujeong @gshiroma
    seongsujeong and gshiroma authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    69072d9 View commit details
    Browse the repository at this point in the history

  4. Update src/s1reader/s1_annotation.py 

    unnecessary comment removed

Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
    @seongsujeong @gshiroma
    seongsujeong and gshiroma authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    de4096e View commit details
    Browse the repository at this point in the history

  5. Docstring clarification

    Seongsu Jeong committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    663c735 View commit details
    Browse the repository at this point in the history

  6. Addressing PEP8 C0301

    Seongsu Jeong committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    90aa6d7 View commit details
    Browse the repository at this point in the history

  7. AuxCal.get_aux_cal_instrument_config_id() - check the instrument conf… 

    …iguration id of the AUX_CAL .zip
    Seongsu Jeong committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    2ce289a View commit details
    Browse the repository at this point in the history

  8. get_path_aux_cal() - check if the instrument configuration ID matches

    Seongsu Jeong committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    2913b29 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. untested refactor to isolate noise loading from annotation

    @LiangJYu
    LiangJYu committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    f019bae View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Merge branch 'main' into noise_refactor

    @LiangJYu
    LiangJYu committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    2a0c138 View commit details
    Browse the repository at this point in the history