WIP noise annotation refactor #69
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the main branch of this fork to update after `s1_annotation.py`
…r implementation for thermal and EAP correction
… `Sentinel1BurstSlc`
Readability improvement on equation Co-authored-by: Liang Yu <[email protected]>
Removing commented out code Co-authored-by: Liang Yu <[email protected]>
Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]>
Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]>
Removing the commented out codes Co-authored-by: Liang Yu <[email protected]>
improvement on code brevity Co-authored-by: Liang Yu <[email protected]>
renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]>
renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]>
Bump isce3 to 0.8 and refresh CI specfile (isce-framework#66)
variable name revised for clarity Co-authored-by: Liang Yu <[email protected]>
variable renamed for clarity Co-authored-by: Liang Yu <[email protected]>
improvement on docstring Co-authored-by: Liang Yu <[email protected]>
Readability improvement of equation Co-authored-by: Liang Yu <[email protected]>
…s1-reader into correction_and_calibration
Renaming variable for clarity Co-authored-by: Liang Yu <[email protected]>
Fix on docstring for `s1_annotation.AuxCal.load_from_zip_file()` Co-authored-by: Liang Yu <[email protected]>
Change on docstring for s1_annotation.BurstEAP._anx2height Co-authored-by: Liang Yu <[email protected]>
updates on s1_reader.get_path_aux_cal() Co-authored-by: Liang Yu <[email protected]>
Readability improvement Co-authored-by: Liang Yu <[email protected]>
…trieve thermal correction LUT
… / suggestions from @Liang Yu
… Comment cleanup
Clarification of the description Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
Clarification on docsctring Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
fix on docstring Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
unnecessary comment removed Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
…iguration id of the AUX_CAL .zip
|
@LiangJYu it is unclear to me why we need this refactor. If I am not wrong, @seongsujeong PR has not merged yet. Can we just be done with those changes in his open PR? I think I am missing or I have lost track of something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on @seongsujeong's work from #62. In the early draft stage, f019bae below is the only relevant commit. I'm unsure if changes here should be a PR submitted to #62 or standalone PR pending #62 merging; currently a standalone for higher visibility.
This PR:
To do: