Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply nan/0 mask to output of goldstein filter #447

Merged

Conversation

scottstanie
Copy link
Collaborator

@scottstanie scottstanie commented Oct 13, 2024

Closes #261

For a current input with rotated phase (e.g. a geocoded interferogram):
image

The edge blocks leave slightly non-zero values (here is using np.ma.masked_equal(phase, 0)):
image

The result of this PR:
image

@scottstanie
Copy link
Collaborator Author

spurt appears to be hanging... at first it was in test_unwrap.py before i made the test size smaller, but the last time it was in tests/test_workflows_displacement.py::test_displacement_run_extra_reference_date[spurt] (never appears in the log). Unsure how to debug, since the tests run fine locally on linux/mac

@scottstanie scottstanie merged commit 3571819 into isce-framework:main Oct 14, 2024
6 checks passed
@scottstanie scottstanie deleted the fix-goldstein-edge-blocks branch October 14, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let goldstein filtering work with partial blocks, mask the result after to match the original
1 participant