Use spawn for all multiprocessing
#48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottstanie
requested review from
gmgunter and
piyushrpt
and removed request for
gmgunter
|
It would be interesting to see how this goes in the production env. This does seem to slow things down on my OSX machine. The reason that things may have worked fast on tests is that reducing the size of the problems might have eliminated any residues - in which case the parallelized bit of code is not exercised. |
The cost calculator needed .points to use distance costs
|
Do we close this PR now that bumping up the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll try and test this more, but I realized that in
dolphin's CI, I hadn't installedspurtto run the optional tests. Once I did, it started hanging indefinitely for anything larger than like 20x20 pixels. I think the reason is some bad combination of the libraries which use threads in earlier tests (see here for long discussion).When I ran the tests with this branch, the went normally.
TODO: check that this doesn't make the temporal unwrapping part very slow.