-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tabs component #73
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
import { Box } from "@/components/Box/Box"; | ||
import { HStack } from "@/components/Stack/Stack"; | ||
import { createContext, ReactNode, useContext, useState } from "react"; | ||
import { css, html } from "react-strict-dom"; | ||
import { Text } from "@/components/Text/Text"; | ||
|
||
const TabsContext = createContext<{ | ||
activeTab: string; | ||
setActiveTab: (tab: string) => void; | ||
}>({ | ||
activeTab: "", | ||
setActiveTab: () => {}, | ||
}); | ||
|
||
function useTabsContext() { | ||
return useContext(TabsContext); | ||
} | ||
|
||
type RootProps = { | ||
children: ReactNode; | ||
defaultValue?: string; | ||
}; | ||
|
||
function Root({ children, defaultValue }: RootProps) { | ||
const [activeTab, setActiveTab] = useState(defaultValue ?? ""); | ||
|
||
return ( | ||
<TabsContext.Provider value={{ activeTab, setActiveTab }}> | ||
{children} | ||
</TabsContext.Provider> | ||
); | ||
} | ||
|
||
type ListProps = { | ||
children: ReactNode; | ||
}; | ||
|
||
function List({ children }: ListProps) { | ||
return ( | ||
<HStack justifyContent="center" borderBottomWidth={1} borderColor="divider"> | ||
{children} | ||
</HStack> | ||
); | ||
} | ||
|
||
type TriggerProps = { | ||
children: ReactNode; | ||
value: string; | ||
}; | ||
|
||
const triggerStyles = css.create({ | ||
wrapper: { | ||
borderWidth: 0, | ||
paddingLeft: 16, | ||
paddingRight: 16, | ||
}, | ||
}); | ||
|
||
function Trigger({ children, value }: TriggerProps) { | ||
const context = useTabsContext(); | ||
const isActive = context.activeTab === value; | ||
|
||
return ( | ||
<html.button | ||
onClick={() => context.setActiveTab(value)} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if active we can add an |
||
style={triggerStyles.wrapper} | ||
> | ||
<Box | ||
borderBottomWidth={2} | ||
borderColor={isActive ? "textPrimary" : "transparent"} | ||
py={4} | ||
> | ||
<Text color={isActive ? "textPrimary" : "textSecondary"}> | ||
{children} | ||
</Text> | ||
</Box> | ||
</html.button> | ||
); | ||
} | ||
|
||
type ContentProps = { | ||
children: ReactNode; | ||
value: string; | ||
}; | ||
|
||
function Content({ children, value }: ContentProps) { | ||
const context = useTabsContext(); | ||
|
||
return context.activeTab === value ? <>{children}</> : null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the content of a tab content area should have a role of |
||
} | ||
|
||
const Tabs = { | ||
Root, | ||
List, | ||
Trigger, | ||
Content, | ||
}; | ||
|
||
export { Tabs }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to make things more accessible, we should have the children here be a
ul
and then we can wrap the trigger elements in anli
.The
ul
can then also have the role oftablist
and eachli
can have a role oftab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, this would be so much easier with polymorphic components :(