Add Tabs component #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgca
commented
Dec 3, 2024
•
dgca
commented
cgjohn
reviewed
Dec 3, 2024
| function List({ children }: ListProps) { | ||
| return ( | ||
| <HStack justifyContent="center" borderBottomWidth={1} borderColor="divider"> | ||
| {children} |
There was a problem hiding this comment.
If we want to make things more accessible, we should have the children here be a ul and then we can wrap the trigger elements in an li.
The ul can then also have the role of tablist and each li can have a role of tab
There was a problem hiding this comment.
Man, this would be so much easier with polymorphic components :(
cgjohn
reviewed
Dec 3, 2024
| function Content({ children, value }: ContentProps) { | ||
| const context = useTabsContext(); | ||
|
|
||
| return context.activeTab === value ? <>{children}</> : null; |
There was a problem hiding this comment.
the content of a tab content area should have a role of tabpanel
cgjohn
reviewed
Dec 3, 2024
|
|
||
| return ( | ||
| <html.button | ||
| onClick={() => context.setActiveTab(value)} |
There was a problem hiding this comment.
if active we can add an aria-selected value here so it reads out as the active tab
cgjohn
approved these changes
Dec 3, 2024
|
Talked on Slack and decided to fix the a11y stuff as a follow up after trying to make polymorphic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.