Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking #42

Merged
merged 11 commits into from
Jun 13, 2019
Merged

Networking #42

merged 11 commits into from
Jun 13, 2019

Conversation

jdonszelmann
Copy link
Contributor

Blocked by #41

@jdonszelmann jdonszelmann requested a review from NULLx76 June 13, 2019 00:02
NULLx76
NULLx76 previously approved these changes Jun 13, 2019
Copy link
Member

@NULLx76 NULLx76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚛

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #42 into develop will decrease coverage by 4.46%.
The diff coverage is 51.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
- Coverage    63.14%   58.68%   -4.47%     
===========================================
  Files           22       24       +2     
  Lines         1175     1646     +471     
  Branches       312      447     +135     
===========================================
+ Hits           742      966     +224     
- Misses         154      264     +110     
- Partials       279      416     +137
Impacted Files Coverage Δ
src/crypto/signature.rs 63.51% <ø> (-2.83%) ⬇️
src/crypto/mod.rs 56.32% <0%> (-2.3%) ⬇️
src/serialization/varlen.rs 55.64% <0%> (ø) ⬆️
src/community/peer.rs 0% <0%> (ø)
src/serialization/header.rs 34.02% <0%> (-0.55%) ⬇️
src/error.rs 69.23% <100%> (-3.5%) ⬇️
src/configuration.rs 45.33% <12.5%> (-54.67%) ⬇️
src/community/mod.rs 12.9% <12.9%> (ø)
src/payloads/binmemberauthenticationpayload.rs 54.83% <50%> (-1.83%) ⬇️
src/crypto/keytypes.rs 53.73% <66.66%> (-5.05%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b58875...e986bf4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #42 into develop will decrease coverage by 3.3%.
The diff coverage is 51.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
- Coverage    63.14%   59.84%   -3.31%     
===========================================
  Files           22       24       +2     
  Lines         1175     1646     +471     
  Branches       312      447     +135     
===========================================
+ Hits           742      985     +243     
- Misses         154      262     +108     
- Partials       279      399     +120
Impacted Files Coverage Δ
src/crypto/signature.rs 63.51% <ø> (-2.83%) ⬇️
src/crypto/mod.rs 56.32% <0%> (-2.3%) ⬇️
src/serialization/varlen.rs 55.64% <0%> (ø) ⬆️
src/community/peer.rs 0% <0%> (ø)
src/serialization/header.rs 34.02% <0%> (-0.55%) ⬇️
src/error.rs 69.23% <100%> (-3.5%) ⬇️
src/configuration.rs 45.33% <12.5%> (-54.67%) ⬇️
src/community/mod.rs 12.9% <12.9%> (ø)
src/payloads/binmemberauthenticationpayload.rs 54.83% <50%> (-1.83%) ⬇️
src/crypto/keytypes.rs 53.73% <66.66%> (-5.05%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b58875...ad45905. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jun 13, 2019

Code Climate has analyzed commit ad45905 and detected 0 issues on this pull request.

View more on Code Climate.

@NULLx76 NULLx76 mentioned this pull request Jun 13, 2019
@dsluijk dsluijk merged commit f3ca505 into develop Jun 13, 2019
@dsluijk dsluijk deleted the networking branch June 13, 2019 11:02
NULLx76 pushed a commit that referenced this pull request Jun 22, 2019
NULLx76 pushed a commit that referenced this pull request Jun 22, 2019
sudo fix-travis

install pipenv from pip
what are repos anyways

why have the latest versions of packages in repos, what would be the use of that?!
~~or why not run ci on docker containers~~

We heard you liked dependencies so we added dependencies to your dependency manager

Signing and verifying now done in rust instead of python

Co-authored-by: Jonathan Dönszelmann <[email protected]>

updated py-ipv8

formatted

updated Pipfile dependencies

install libssl to download pipenv dependencies

add openssl

install with pip3

python3.7 + pip

ensure pip #42

fuck travis
commit message courtesy of:

Co-authored-by: Jonathan Dönszelmann <[email protected]>

Travis docs were wrong, what a suprise

guess updating ubuntu may help idk, kinda want to run gitlab-ci inside of travis now

next up: what are version numbers anyway

python without pip, c'mon travis are you even trying?

why did you even make the 'python' command in your yml....

travis sucks

ubuntu + travis sucks more

how long will this go on for

yes

no

getting salty

y
NULLx76 pushed a commit that referenced this pull request Jun 22, 2019
sudo fix-travis

install pipenv from pip
what are repos anyways

why have the latest versions of packages in repos, what would be the use of that?!
~~or why not run ci on docker containers~~

We heard you liked dependencies so we added dependencies to your dependency manager

Signing and verifying now done in rust instead of python

Co-authored-by: Jonathan Dönszelmann <[email protected]>

updated py-ipv8

formatted

updated Pipfile dependencies

install libssl to download pipenv dependencies

add openssl

install with pip3

python3.7 + pip

ensure pip #42

fuck travis
commit message courtesy of:

Co-authored-by: Jonathan Dönszelmann <[email protected]>

Travis docs were wrong, what a suprise

guess updating ubuntu may help idk, kinda want to run gitlab-ci inside of travis now

next up: what are version numbers anyway

python without pip, c'mon travis are you even trying?

why did you even make the 'python' command in your yml....

travis sucks

ubuntu + travis sucks more

how long will this go on for

yes

no

getting salty

y
NULLx76 pushed a commit that referenced this pull request Jun 22, 2019
sudo fix-travis

install pipenv from pip
what are repos anyways

why have the latest versions of packages in repos, what would be the use of that?!
~~or why not run ci on docker containers~~

We heard you liked dependencies so we added dependencies to your dependency manager

Signing and verifying now done in rust instead of python

Co-authored-by: Jonathan Dönszelmann <[email protected]>

updated py-ipv8

formatted

updated Pipfile dependencies

install libssl to download pipenv dependencies

add openssl

install with pip3

python3.7 + pip

ensure pip #42

fuck travis
commit message courtesy of:

Co-authored-by: Jonathan Dönszelmann <[email protected]>

Travis docs were wrong, what a suprise

guess updating ubuntu may help idk, kinda want to run gitlab-ci inside of travis now

next up: what are version numbers anyway

python without pip, c'mon travis are you even trying?

why did you even make the 'python' command in your yml....

travis sucks

ubuntu + travis sucks more

how long will this go on for

yes

no

getting salty

y

Co-authored-by: Jonathan Dönszelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants