-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some refactoring #43
Some refactoring #43
Conversation
Co-Authored-By: Jonathan Dönszelmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me
( non biased review, commit totally not made by me)
Codecov Report
@@ Coverage Diff @@
## develop #43 +/- ##
===========================================
+ Coverage 60.02% 64.35% +4.32%
===========================================
Files 24 23 -1
Lines 1571 1641 +70
Branches 432 454 +22
===========================================
+ Hits 943 1056 +113
+ Misses 234 210 -24
+ Partials 394 375 -19
Continue to review full report at Codecov.
|
Co-Authored-By: Jonathan Dönszelmann <[email protected]>
Code Climate has analyzed commit 6c7c340 and detected 0 issues on this pull request. View more on Code Climate. |
Blocked by #42