Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactoring #43

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Some refactoring #43

merged 3 commits into from
Jun 13, 2019

Conversation

NULLx76
Copy link
Member

@NULLx76 NULLx76 commented Jun 13, 2019

Blocked by #42

@NULLx76 NULLx76 requested review from dsluijk and jdonszelmann June 13, 2019 10:38
jdonszelmann
jdonszelmann previously approved these changes Jun 13, 2019
Copy link
Contributor

@jdonszelmann jdonszelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

( non biased review, commit totally not made by me)

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #43 into develop will increase coverage by 4.32%.
The diff coverage is 80.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    60.02%   64.35%   +4.32%     
===========================================
  Files           24       23       -1     
  Lines         1571     1641      +70     
  Branches       432      454      +22     
===========================================
+ Hits           943     1056     +113     
+ Misses         234      210      -24     
+ Partials       394      375      -19
Impacted Files Coverage Δ
src/lib.rs 69.23% <ø> (ø) ⬆️
src/community/peer.rs 82.75% <73.68%> (+82.75%) ⬆️
src/networking/mod.rs 71.27% <77.77%> (-0.47%) ⬇️
src/networking/address.rs 72.72% <80%> (+19.78%) ⬆️
src/community/mod.rs 55.4% <85.71%> (+36.35%) ⬆️
src/serialization/header.rs 35.05% <0%> (+1.03%) ⬆️
src/serialization/mod.rs 72.58% <0%> (+2.31%) ⬆️
src/crypto/signature.rs 68.91% <0%> (+5.4%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ca505...6c7c340. Read the comment docs.

Co-Authored-By: Jonathan Dönszelmann <[email protected]>
@jdonszelmann jdonszelmann self-requested a review June 13, 2019 11:02
@codeclimate
Copy link

codeclimate bot commented Jun 13, 2019

Code Climate has analyzed commit 6c7c340 and detected 0 issues on this pull request.

View more on Code Climate.

@NULLx76 NULLx76 merged commit 6a1bf33 into develop Jun 13, 2019
@NULLx76 NULLx76 deleted the refactor branch June 13, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants