Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the basis of communities. #41

Merged
merged 5 commits into from
Jun 13, 2019
Merged

Added the basis of communities. #41

merged 5 commits into from
Jun 13, 2019

Conversation

jdonszelmann
Copy link
Contributor

Co-authored-by: Victor Roest [email protected]

Co-authored-by: Victor Roest <[email protected]>
@jdonszelmann
Copy link
Contributor Author

note: Added lazy static

@jdonszelmann jdonszelmann requested review from NULLx76 and dsluijk and removed request for NULLx76 June 11, 2019 20:02
NULLx76
NULLx76 previously approved these changes Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #41 into develop will decrease coverage by 7.12%.
The diff coverage is 31.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
- Coverage    63.14%   56.02%   -7.13%     
===========================================
  Files           22       24       +2     
  Lines         1175     1387     +212     
  Branches       312      369      +57     
===========================================
+ Hits           742      777      +35     
- Misses         154      282     +128     
- Partials       279      328      +49
Impacted Files Coverage Δ
src/lib.rs 0% <0%> (-100%) ⬇️
src/community/peer.rs 0% <0%> (ø)
src/configuration.rs 0% <0%> (-100%) ⬇️
src/community/mod.rs 0% <0%> (ø)
src/crypto/keytypes.rs 53.73% <66.66%> (-5.05%) ⬇️
src/serialization/mod.rs 70.07% <72.22%> (-9%) ⬇️
src/payloads/connectiontype.rs 57.14% <0%> (-14.29%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b58875...f9cdb0c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #41 into develop will decrease coverage by 4.34%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #41      +/-   ##
==========================================
- Coverage    63.14%   58.8%   -4.35%     
==========================================
  Files           22      22              
  Lines         1175    1175              
  Branches       312     312              
==========================================
- Hits           742     691      -51     
- Misses         154     207      +53     
+ Partials       279     277       -2
Impacted Files Coverage Δ
src/configuration.rs 0% <0%> (-100%) ⬇️
src/lib.rs 0% <0%> (-100%) ⬇️
src/crypto/keytypes.rs 58.77% <100%> (ø) ⬆️
src/serialization/mod.rs 71.51% <64.28%> (-7.56%) ⬇️
src/payloads/connectiontype.rs 57.14% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b58875...c091b5e. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jun 11, 2019

Code Climate has analyzed commit c091b5e and detected 0 issues on this pull request.

View more on Code Climate.

@jdonszelmann jdonszelmann mentioned this pull request Jun 13, 2019
@dsluijk dsluijk merged commit ccfa197 into develop Jun 13, 2019
@dsluijk dsluijk deleted the community branch June 13, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants