Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workflows to use ubuntu-latest #1682

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

Use workflows to use ubuntu-latest #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/covector.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ jobs:
# XXX: The GitHub hosted Windows 2022 image comes with Visual Studio 2022, but node-gyp
# (which is used by neon-sys) sadly fails to recognize it. As a mitigation, we still run the
# tests on Windows 2019, until we can figure out a way to fix the problem.
# NOTE: Using Ubuntu 18.04 to provide glibc compatibility. (#588)
os: [ubuntu-18.04, macos-latest, windows-2019]
os: [ubuntu-latest, macos-latest, windows-2019]
node: ['12', '14', '16']
exclude:
# FIXME: fatal error C1083: Cannot open include file: 'node.h': No such file or directory
Expand Down Expand Up @@ -129,8 +128,7 @@ jobs:
# XXX: The GitHub hosted Windows 2022 image comes with Visual Studio 2022, but node-gyp
# (which is used by neon-sys) sadly fails to recognize it. As a mitigation, we still run the
# tests on Windows 2019, until we can figure out a way to fix the problem.
# NOTE: Using Ubuntu 18.04 to provide glibc compatibility. (#588)
os: [ubuntu-18.04, macos-latest, windows-2019]
os: [ubuntu-latest, macos-latest, windows-2019]

steps:
- name: Checkout the Source Code
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/python-bindings-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,10 @@ jobs:
strategy:
fail-fast: false
matrix:
# Using Ubuntu 18.04 to provide glibc compatibility. (#588)
os: [ubuntu-18.04, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
python: ['3.9']
include:
- os: ubuntu-18.04
- os: ubuntu-latest
identifier: linux
- os: macos-latest
identifier: macos
Expand Down