Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workflows to use ubuntu-latest #1682

Open
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

Dr-Electron
Copy link
Collaborator

Description of change

Updated all workflows to use ubuntu-latest as 18.04 is depreciated.
Seems like #588 isn't a Problem anymore? At least python wheels were build perfectly fine in my fork.

But I'm not sure how to run the covector action and it fails for me, because it can't find iotaledger/create-pull-request

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Run the python workflow in my fork

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#588 was never a problem for building, only when running something from a newer version on ubuntu 18

@Dr-Electron
Copy link
Collaborator Author

Dr-Electron commented Jun 12, 2023

Understood. But we need to find a solution for this otherwise we can't publish the bindings for Ubuntu. And as Ubuntu 18 is basically EoL I guess it would be fine to not support it 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants