minor tweaks to project file

ionide · Apr 15, 2022 · 012b9a9 · 012b9a9
1 parent 1cde03e
commit 012b9a9
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/Ionide.KeepAChangelog.Tasks/Ionide.KeepAChangelog.Tasks.fsproj b/src/Ionide.KeepAChangelog.Tasks/Ionide.KeepAChangelog.Tasks.fsproj
@@ -2,17 +2,17 @@
 
   <PropertyGroup>
     <TargetFrameworks>net472;net6.0</TargetFrameworks>
-    <!-- we need the assemblies bundled, so set this so we don't expose any dependencies to the outside world -->
-    <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
-    <TargetsForTfmSpecificBuildOutput>$(TargetsForTfmSpecificBuildOutput);CopyProjectReferencesToPackage</TargetsForTfmSpecificBuildOutput>
     <DebugType>embedded</DebugType>
     <IsPackable>true</IsPackable>
     <Description>MSBuild Tasks and Targets that set your Assembly Version, Package Version, and Package Release Notes from your KeepAChangelog-compatible Changelogs.</Description>
-    <EnableDynamicLoading>true</EnableDynamicLoading>
-    <GenerateDependencyFile>true</GenerateDependencyFile>
-    <!-- <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> -->
+
+    <!-- we need the assemblies bundled, so set this so we don't expose any dependencies to the outside world -->
+    <TargetsForTfmSpecificBuildOutput>$(TargetsForTfmSpecificBuildOutput);CopyProjectReferencesToPackage</TargetsForTfmSpecificBuildOutput>
     <NoWarn>NU5128;NU5100</NoWarn><!-- NU5100 is because we pack to tasks/, not lib/ -->
     <BuildOutputTargetFolder>tasks</BuildOutputTargetFolder>
+
+    <!-- deps.json generation -->
+    <GenerateDependencyFile>true</GenerateDependencyFile>
   </PropertyGroup>
 
   <ItemGroup>
@@ -31,6 +31,8 @@
         PackagePath="buildMultiTargeting\" />
   </ItemGroup>
   <ItemGroup>
+    <!-- All dependencies need PrivateAssets="all" not flow as a nuget-dependency to consumers -->
+    <!-- MSBUC specifically-->
     <PackageReference
         Include="Microsoft.Build.Utilities.Core"
         Version="17.0.0"