Skip to content

Commit

Permalink
fix packaging logic for non-core msbuilds
Browse files Browse the repository at this point in the history
  • Loading branch information
baronfel committed Apr 15, 2022
1 parent aaa6e4d commit 1cde03e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## [0.1.8] - 2022.03.31

### Changed

* Minor packaging fix for non-Core MSBuild versions

## [0.1.7] - 2022.03.31

### Changed
Expand Down
5 changes: 2 additions & 3 deletions src/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
<Project>
<PropertyGroup>
<Version>0.1.7</Version>
<Version>0.1.8</Version>
<PackageReleaseNotes>
### Changed

* Better packaging of the task to prevent task DLL dependencies from impacting your project's dependencies
* Updated the parser to provide to `ToMarkdown()` member for more general use
* Minor packaging fix for non-Core MSBuild versions
</PackageReleaseNotes>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@
$(GetPackageVersionDependsOn);
</GetPackageVersionDependsOn>

<_Ionide_KeepAChangelog_Tasks_TFM Condition=" '$(MSBuildRuntimeType)' == 'Full' ">net472</_Ionide_KeepAChangelog_Tasks_TFM>
<_Ionide_KeepAChangelog_Tasks_TFM Condition=" '$(MSBuildRuntimeType)' != 'Core' ">net472</_Ionide_KeepAChangelog_Tasks_TFM>
<_Ionide_KeepAChangelog_Tasks_TFM Condition=" '$(MSBuildRuntimeType)' == 'Core' ">net6.0</_Ionide_KeepAChangelog_Tasks_TFM>
<_Ionide_KeepAChangelog_Tasks_TFM Condition="'$(_Ionide_KeepAChangelog_Tasks_TFM)' == '' ">net6.0</_Ionide_KeepAChangelog_Tasks_TFM>
</PropertyGroup>

<UsingTask
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@
$(GetPackageVersionDependsOn);
</GetPackageVersionDependsOn>

<_Ionide_KeepAChangelog_Tasks_TFM Condition=" '$(MSBuildRuntimeType)' == 'Full' ">net472</_Ionide_KeepAChangelog_Tasks_TFM>
<_Ionide_KeepAChangelog_Tasks_TFM Condition=" '$(MSBuildRuntimeType)' != 'Core' ">net472</_Ionide_KeepAChangelog_Tasks_TFM>
<_Ionide_KeepAChangelog_Tasks_TFM Condition=" '$(MSBuildRuntimeType)' == 'Core' ">net6.0</_Ionide_KeepAChangelog_Tasks_TFM>
<_Ionide_KeepAChangelog_Tasks_TFM Condition="'$(_Ionide_KeepAChangelog_Tasks_TFM)' == '' ">net6.0</_Ionide_KeepAChangelog_Tasks_TFM>
</PropertyGroup>

<UsingTask
Expand Down

0 comments on commit 1cde03e

Please sign in to comment.