feat: optimized board queries #6931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
github-actions
bot
added
api
python
5 tasks
Use SQL instead of python to retrieve image count, asset count and board cover image. This reduces the number of SQL queries needed to list all boards. Previously, we did `1 + 2 * board_count` queries:: - 1 query to get the list of board records - 1 query per board to get its total count - 1 query per board to get its cover image Then, on the frontend, we made two additional network requests to get each board's counts: - 1 request (== 1 SQL query) for image count - 1 request (== 1 SQL query) for asset count All of this information is now retrieved in a single SQL query, and provided via single network request. As part of this change, `BoardRecord` now includes `image_count`, `asset_count` and `cover_image_name`. This makes `BoardDTO` redundant, but removing it is a deeper change...
- Update tooltips to use counts in the DTO - Remove unused `getBoardImagesTotal` and `getBoardAssetsTotal` queries, which were just abusing the list endpoint to get totals... - Remove extraneous optimistic update in invocation complete listener
psychedelicious
force-pushed
the
psyche/optimized-board-count-queries
branch
from
5ddcf82
to
a091942
Compare
Now that the counts are already available and the tooltip does not make a network request, we can remove the delay (which was added to prevent network thrashing as you moved the mouse over the boards list).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6603 I made some changes to reduce SQL queries and network requests when listing boards. That PR got crusty, this PR updates it to work on
main.Two main changes.
feat(app): add method & route to get uncategorized image counts
Previously we were abusing the list boards query (twice!) to get the counts for uncategorized images/assets. There is now a dedicated endpoint for this.
feat(app): optimize boards queries
Related Issues / Discussions
main)QA Instructions
Needs re-review from @maryhipp.
Board counts should be correct and update as images are moved between boards and generated/saved to gallery.
Merge Plan
This should only be merged after v5 is released.
Checklist