Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): optimized boards queries #6603

Closed
wants to merge 12 commits into from
Closed

feat(ui): optimized boards queries #6603

wants to merge 12 commits into from

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Jul 12, 2024 •
edited
Loading

Summary

Optimize board related queries, reducing the number of SQL queries and network requests needed to list boards.

  • Add method and endpoint to get uncategorized image counts
  • Update board methods to use single queries to retrieve single and multiple boards
  • Update UI to use the new endpoint

Fixes incorrect board image counts.

Related Issues / Discussions

n/a

QA Instructions

The UI should list boards and their counts accurately, and moving images around in a board should work as it did before.

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added api python PRs that change python files services PRs that change app services frontend PRs that change frontend files python-tests PRs that change python tests labels Jul 12, 2024
Base automatically changed from psyche/feat/ui/gallery-followups to main July 12, 2024 04:25
@psychedelicious psychedelicious mentioned this pull request Jul 12, 2024
Closed
3 tasks
@psychedelicious
feat(app): add get_uncategorized_image_counts method on board_records…
c74b9a4 
… service
@psychedelicious
feat(api): add get_uncategorized_image_counts endpoint
a95aa6c
@psychedelicious
feat(app): refactor board record to include image & asset counts and …
c05f97d 
…cover image

This _substantially_ reduces the number of queries required to list all boards. A single query now gets one, all, or a page of boards, including counts and cover image name.

- Add helpers to build the queries, which share a common base with some joins.
- Update `BoardRecord` to include the counts.
- Update `BoardDTO`, which is now identical to `BoardRecord`. I opted to not remove `BoardDTO` because it is used in many places.
- Update boards high-level service and board records services accordingly.
@psychedelicious
tests(app): fix bulk downloads test
0484f45
@psychedelicious
chore(ui): typegen
2843a6a 
chore(ui): typegen
@psychedelicious
feat(ui): use new uncategorized image counts & updated list boards qu…
a6f1148 
…eries
@psychedelicious
fix(ui): remove unused queries and fix invocation complete listener
a30d143
@psychedelicious
tidy(app): move sqlite-specific objects to sqlite file
25107e4
@psychedelicious
tidy(app): remove extraneous condition from query
c586d65
@psychedelicious
docs(app): add comments to boards queries
9d3a72f
@psychedelicious
Copy link
Collaborator Author

  • Addressed feedback, organizing objects.
  • Added comments to queries.
  • Removed extraneous condition in query.

maryhipp
maryhipp approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@maryhipp maryhipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psychedelicious psychedelicious marked this pull request as draft July 15, 2024 21:12
@psychedelicious
Copy link
Collaborator Author

Marked draft to prevent premature merge.

@psychedelicious psychedelicious mentioned this pull request Sep 24, 2024
Open
3 tasks
@psychedelicious
Copy link
Collaborator Author

Superseded by #6931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@maryhipp maryhipp maryhipp approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

Assignees
No one assigned
Labels
api frontend PRs that change frontend files python PRs that change python files python-tests PRs that change python tests services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psychedelicious @maryhipp @hipsterusername