-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker update #8538
Docker update #8538
Conversation
SchrodingersGat
commented
Nov 22, 2024
- Simplify docker setup procedure
- Now uses a pre-baked custom Caddy container
- Closes [Docker] Custom docker container for Caddy proxy #6920
- Ref: https://github.com/inventree/inventree-caddy
- Ref: https://hub.docker.com/r/inventree/inventree-caddy
- Point to the inventree-caddy image
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
@SchrodingersGat what is not really clear to me is the plan regarding keeping the image up to date with both upstream (caddy and inventree). Will there be a release for each caddy release and each inventree release? How does a user determine if they have the right container if we need to change the settings (for #7724 for example)? |
I personally find this setup much more complex than just downloading an extra Caddyfile, I mean I still have to download the extra .env file, why not also download an Caddyfile. We may could provide something like this to just copy to download all required files by one command: curl --remote-name-all https://raw.githubusercontent.com/inventree/inventree/stable/contrib/container/{docker-compose.yml,.env,Caddyfile} |
All reasonable points. On balance I don't think this is worth pursuing any further. |
Another idea would be to generate a new |