Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker update #8538

Closed
Closed

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature docker Docker / docker-compose setup Relates to the InvenTree setup / installation process documentation labels Nov 22, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 22, 2024
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit f4c9d20
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/673fcf2acee324000879efd5

@matmair
Copy link
Member

matmair commented Nov 23, 2024

@SchrodingersGat what is not really clear to me is the plan regarding keeping the image up to date with both upstream (caddy and inventree). Will there be a release for each caddy release and each inventree release? How does a user determine if they have the right container if we need to change the settings (for #7724 for example)?

@wolflu05
Copy link
Contributor

I personally find this setup much more complex than just downloading an extra Caddyfile, I mean I still have to download the extra .env file, why not also download an Caddyfile. We may could provide something like this to just copy to download all required files by one command:

curl --remote-name-all https://raw.githubusercontent.com/inventree/inventree/stable/contrib/container/{docker-compose.yml,.env,Caddyfile}

@SchrodingersGat
Copy link
Member Author

All reasonable points. On balance I don't think this is worth pursuing any further.

@SchrodingersGat SchrodingersGat deleted the docker-update branch November 23, 2024 20:36
@SchrodingersGat
Copy link
Member Author

Another idea would be to generate a new Caddyfile into the shared volume (externally mounted) if one does not already exist (like we already do for config.yaml or plugins.txt), Then, the caddy image can make use of that when it launches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker / docker-compose documentation enhancement This is an suggested enhancement or new feature setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docker] Custom docker container for Caddy proxy
3 participants